Closed Bug 1275076 Opened 8 years ago Closed 8 years ago

convert the manifest of the clock app

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Clock
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jovan.gerodetti, Assigned: jovan.gerodetti)

References

Details

Attachments

(2 files)

[gaia] TitanNano:bug_1275076 > mozilla-b2g:kanikani
46 bytes, text/x-github-pull-request
jovan.gerodetti
: review-
Details | Review
[gaia] TitanNano:bug_1275076 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
benfrancis
: review+
Details | Review 
The clock app's manifest needs to be converted to be a standart conform web app manifest and a link tag should be placed in the index.html


Alberto, can you assign me to this?
Flags: needinfo?(apastor)
Blocks: 1275072, 1274928
Assignee: nobody → titannanomail
Flags: needinfo?(apastor)
Attachment #8768125 - Flags: review?(apastor)
Attachment #8768125 - Flags: review?(apastor) → review?(bfrancis)
Comment on attachment 8768125 [details] [review]
[gaia] TitanNano:bug_1275076 > mozilla-b2g:kanikani

Thanks for this patch, sorry for the delay. I left some comments on GitHub.
Attachment #8768125 - Flags: review?(bfrancis)
Comment on attachment 8768125 [details] [review]
[gaia] TitanNano:bug_1275076 > mozilla-b2g:kanikani

I removed the mentioned members form the manifest and left some comments on GitHub.
Attachment #8768125 - Flags: review?(bfrancis)
Attachment #8768125 - Flags: review?(bfrancis) → review-
Attachment #8776644 - Flags: review?(bfrancis)
Comment on attachment 8776644 [details] [review]
[gaia] TitanNano:bug_1275076 > mozilla-b2g:master

Thanks for this patch!
Attachment #8776644 - Flags: review?(bfrancis) → review+
https://github.com/mozilla-b2g/gaia/commit/90240f7a2e66ae8873e1f1b0e5f1d80a98c2c2db
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: