convert the manifest of the clock app

RESOLVED FIXED

Status

Firefox OS
Gaia::Clock
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Jovan Gerodetti, Assigned: Jovan Gerodetti)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
The clock app's manifest needs to be converted to be a standart conform web app manifest and a link tag should be placed in the index.html


Alberto, can you assign me to this?
Flags: needinfo?(apastor)
(Assignee)

Updated

2 years ago
Blocks: 1275072, 1274928
Assignee: nobody → titannanomail
Flags: needinfo?(apastor)
Created attachment 8768125 [details] [review]
[gaia] TitanNano:bug_1275076 > mozilla-b2g:kanikani
(Assignee)

Updated

2 years ago
Attachment #8768125 - Flags: review?(apastor)
(Assignee)

Updated

2 years ago
Attachment #8768125 - Flags: review?(apastor) → review?(bfrancis)
Comment on attachment 8768125 [details] [review]
[gaia] TitanNano:bug_1275076 > mozilla-b2g:kanikani

Thanks for this patch, sorry for the delay. I left some comments on GitHub.
Attachment #8768125 - Flags: review?(bfrancis)
(Assignee)

Comment 3

2 years ago
Comment on attachment 8768125 [details] [review]
[gaia] TitanNano:bug_1275076 > mozilla-b2g:kanikani

I removed the mentioned members form the manifest and left some comments on GitHub.
Attachment #8768125 - Flags: review?(bfrancis)
Created attachment 8776644 [details] [review]
[gaia] TitanNano:bug_1275076 > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Attachment #8768125 - Flags: review?(bfrancis) → review-
(Assignee)

Updated

2 years ago
Attachment #8776644 - Flags: review?(bfrancis)
Comment on attachment 8776644 [details] [review]
[gaia] TitanNano:bug_1275076 > mozilla-b2g:master

Thanks for this patch!
Attachment #8776644 - Flags: review?(bfrancis) → review+
https://github.com/mozilla-b2g/gaia/commit/90240f7a2e66ae8873e1f1b0e5f1d80a98c2c2db
Status: UNCONFIRMED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.