Closed Bug 1275216 Opened 8 years ago Closed 8 years ago

WebRTC : TCP+TURN+proxy=crash

Categories

(Core :: WebRTC: Signaling, defect, P1)

49 Branch
x86_64
Windows 8.1
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: roudakov.michael, Assigned: drno)

References

Details

Crash Data

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160523030225

Steps to reproduce:

Firefox 48, 49 (Nightly) Win 8.1 crashes after setLocalDescription() (for example https://apprtc.appspot.com/)
SYN packet isn't sent.
Conditions: TURN, TCP, proxy.




Actual results:

crash:
https://crash-stats.mozilla.com/report/index/bp-078459d8-d959-4993-ac16-828c02160524
Crash Signature: IPCError-browser | (msgtype=0xEC0003,name=PTCPSocket::Msg_Data) Processing error: message was deserialized, but the han
OS: Unspecified → Windows 8.1
Hardware: Unspecified → x86_64
Component: Untriaged → WebRTC
Product: Firefox → Core
I set it to new since it contains the crash report.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Rank: 15
Component: WebRTC → WebRTC: Signaling
Priority: -- → P1
Sorry the crash report in this case actually does not tell me exactly where the problem is.

Do you know if this problem affects only Windows?
One guess from mys side is that this problem might be specific to the combination of TCP+TURN+proxy only if multi-process is enabled. As I currently don't have access to a Windows machine to test this would it be possible for you to check if you can repro the problem when you turn on or off the multi-process feature in about:preferences on the General tab?
Flags: needinfo?(roudakov.michael)
See Also: → 1279514
> Do you know if this problem affects only Windows?
I don't know. No linux with GUI in our lab.

> it be possible for you to check if you can repro the problem when you turn on or
> off the multi-process feature in about:preferences on the General tab?
You're right: No crash with disabled multi-process.
Also reproducible with version 48.0b3 on Linux:
https://crash-stats.mozilla.com/report/index/3fd6cac3-01a8-4843-a772-d6f572160628
Disabling multi-process helps to avoid crash. I'm using the same profile for beta, aurora and nightly and I guess it was enabled when I tested with nightly.
Nils -- You have the most context for this.  I've also assigned bug 1279514 to you.  If you have trouble reproducing, let me know as soon as you can.  We can pull in jesup and bwc as needed.  Given this appears to be an e10s-specific regression and e10s is going live in Fx48, I want to try hard to get these bugs fixed this week. Thanks!
Assignee: nobody → drno
Rank: 15 → 11
Explanation: the code from bug 1244926 prevents us from doing an HTTP CONNECT.
Depends on: 1244926
Flags: needinfo?(roudakov.michael)
Depends on: 1285318
I just verified that for me the latest Firefox Beta 48.0b7 fixes the problem. Is it also fixed for you?
Flags: needinfo?(roudakov.michael)
>Is it also fixed for you?
48.0b7 - No crash, but I don't see multi-process flag in preferences for Beta.
50.0a1 (2016-07-12) - No crash for both: multi-process "on" and "off"
Flags: needinfo?(roudakov.michael)
Fixed for me. Tested with:
- Firefox Beta 48.0b7
- Firefox Developer Edition 49.0a2 (2016-07-13)
(In reply to roudakov.michael from comment #9)
> >Is it also fixed for you?
> 48.0b7 - No crash, but I don't see multi-process flag in preferences for
> Beta.
> 50.0a1 (2016-07-12) - No crash for both: multi-process "on" and "off"

AFAIK there is not going to be an option to turn multi-process on or off once it gets rolled out in Beta or Release (on purpose). And it is currently not planed to add that option. Having that option in Nightly and DevEdition is only to ease development.

Thanks for verifying so quickly! Appreciated.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.