Turn off WebRTC TCP packet filter for e10s

RESOLVED FIXED in Firefox 48

Status

()

P1
normal
Rank:
11
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: drno, Assigned: drno)

Tracking

(Blocks: 1 bug, {regression})

48 Branch
mozilla50
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s?, firefox48 fixed, firefox49 fixed, firefox50 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bugs 1279514 and 1275216 revealed that with the current implementation of the TCP packet filter for e10s users who use a HTTP proxy and try to use a WebRTC service which provides a TURN TCP server will experience an (intended) content process crash.
The problem is that the TCP filter from bug 1244926 only allows STUN packets as the initial packets to be exchanged over a TCP connection created by WebRTC content. But in case of an HTTP proxy is used first an HTTP CONNECT is send to the proxy and only after the proxy responded with a 200 OK our implementation starts to send STUN packets to the TURN server.

We need to find a different solution then the code in bug 1244926 to handle all possible scenarios which can occur over a WebRTC TCP connection.

To prevent a regression from the users perspective when e10s gets turned on for them (using TURN TCP through an HTTP proxy works without e10s) we need to turn the packet filtering off until we have a better solution.
(Assignee)

Comment 1

2 years ago
Created attachment 8768873 [details]
Bug 1285318: turn of WebRTC TCP packet filtering.

Review commit: https://reviewboard.mozilla.org/r/62906/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62906/
Attachment #8768873 - Flags: review?(mfroman)
(Assignee)

Updated

2 years ago
Attachment #8768873 - Flags: review?(mfroman)
(Assignee)

Updated

2 years ago
Blocks: 1285330
(Assignee)

Comment 2

2 years ago
Comment on attachment 8768873 [details]
Bug 1285318: turn of WebRTC TCP packet filtering.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62906/diff/1-2/
Attachment #8768873 - Flags: review?(mfroman)
Comment on attachment 8768873 [details]
Bug 1285318: turn of WebRTC TCP packet filtering.

https://reviewboard.mozilla.org/r/62906/#review59814

Looks good to me.
Attachment #8768873 - Flags: review?(mfroman) → review+
(Assignee)

Comment 4

2 years ago
Comment on attachment 8768873 [details]
Bug 1285318: turn of WebRTC TCP packet filtering.

Approval Request Comment
[Feature/regressing bug #]: 1244926 introduce a new packet filter

[User impact if declined]: For users who have a HTTP proxy configured in FF and try to a WebRTC service with a TURN TCP relay (good WebRTC service do provide one to increase chance for a successful call) the content process under e10s crashes.

[Describe test coverage new/current, TreeHerder]: manual testing only.

[Risks and why]: no risk as it only turns off the feature which got added in bug 1244926.

[String/UUID change made/needed]: N/A
Attachment #8768873 - Flags: approval-mozilla-beta?
Attachment #8768873 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

2 years ago
status-firefox48: --- → affected
status-firefox49: --- → affected
status-firefox50: --- → affected
tracking-e10s: --- → ?
(Assignee)

Updated

2 years ago
backlog: --- → webrtc/webaudio+
Rank: 11

Comment 5

2 years ago
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/b6984012fb0b
turn of WebRTC TCP packet filtering. r=mjf

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b6984012fb0b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment on attachment 8768873 [details]
Bug 1285318: turn of WebRTC TCP packet filtering.

Revert to previous behavior to avoid a crash, let's try it. This should be in beta 7 build next Monday.
Attachment #8768873 - Flags: approval-mozilla-beta?
Attachment #8768873 - Flags: approval-mozilla-beta+
Attachment #8768873 - Flags: approval-mozilla-aurora?
Attachment #8768873 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.