1275355 - Move host_jskwgen invocation to moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

This just requires a little wrapper script to invoke host_jskwgen from moz.build.

Comment 1

[Michael Shal [:mshal]]

Attachment: MozReview Request: Bug 1275355 - Move host_jskwgen invocation to moz.build; r?chmanchester

Review commit: https://reviewboard.mozilla.org/r/54910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54910/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8755970 [details]
MozReview Request: Bug 1275355 - Move host_jskwgen invocation to moz.build; r?chmanchester

https://reviewboard.mozilla.org/r/54910/#review51598

::: js/src/jsautokw.py:21
(Diff revision 1)
> +if __name__ == '__main__':
> +    main(sys.stdout, *sys.argv[1:])

You could use the `script = <file>:main` syntax to avoid this, if that seems worthwhile.

Comment 3

[Michael Shal [:mshal]]

It looks like we default to ":main" if no method is specified, so when invoked from the build system it doesn't actually use that part of the script: https://dxr.mozilla.org/mozilla-central/rev/5511d54a3f172c1d68f98cc55dce4de1d0ba1b51/python/mozbuild/mozbuild/frontend/emitter.py#1049

I think that block can still be useful to just run the script manually at the command-line for debugging though, like:

$ python js/src/jsautokw.py objdir/js/src/host_jskwgen

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37be4f51e6b4

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/37be4f51e6b4