1275439 - rename MOZ_LOG_MODULES to just MOZ_LOG

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Ralph Giles (:rillian)]

Shorter env variables are easier to type.

Comment 1

[Ralph Giles (:rillian)]

Attachment: MozReview Request: Bug 1275439 - Switch debugging to MOZ_LOG. r?erahm

This is shorter than MOZ_LOG_MODULES and equally clear.

Also add a deprecation warning to encourge folks to migrate.

Review commit: https://reviewboard.mozilla.org/r/54986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54986/

Comment 2

[Ralph Giles (:rillian)]

I realize it's been a while, but you said you'd look favourably on this change. I've been using it locally for a bit and really appreciating it.

Comment 3

[Eric Rahm [:erahm]]

Comment on attachment 8756145 [details]
MozReview Request: Bug 1275439 - Switch debugging to MOZ_LOG. r?erahm

https://reviewboard.mozilla.org/r/54986/#review51650

This seems fine, but can you update the references in runtests [1] before landing?

[1] https://dxr.mozilla.org/mozilla-central/rev/829d3be6ba648b838ee1953fdfa1a477dace752f/testing/mochitest/runtests.py

Comment 4

[Honza Bambas (:mayhemer)]

Yes, and also in child process launch code (please apply over bug 1270752).  Probably overlook patches in bug 1248565 what all places need to be updated.

Comment 5

[Ralph Giles (:rillian)]

I've updated runtests.py. I don't see any MOZ_LOG_MODULES changes in the child process launch code in bug 1248565.

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8756145 [details]
MozReview Request: Bug 1275439 - Switch debugging to MOZ_LOG. r?erahm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54986/diff/1-2/

Comment 7

[Eric Rahm [:erahm]]

Comment on attachment 8756145 [details]
MozReview Request: Bug 1275439 - Switch debugging to MOZ_LOG. r?erahm

https://reviewboard.mozilla.org/r/54986/#review52004

lgtm

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35574c1aa969

Comment 9

[Ralph Giles (:rillian)]

Thanks. Bug 1270752 hasn't landed yet, so better to do the fixup there.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/35574c1aa969