Closed Bug 1275439 Opened 3 years ago Closed 3 years ago

rename MOZ_LOG_MODULES to just MOZ_LOG

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

Shorter env variables are easier to type.
This is shorter than MOZ_LOG_MODULES and equally clear.

Also add a deprecation warning to encourge folks to migrate.

Review commit: https://reviewboard.mozilla.org/r/54986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54986/
Attachment #8756145 - Flags: review?(erahm)
I realize it's been a while, but you said you'd look favourably on this change. I've been using it locally for a bit and really appreciating it.
Comment on attachment 8756145 [details]
MozReview Request: Bug 1275439 - Switch debugging to MOZ_LOG. r?erahm

https://reviewboard.mozilla.org/r/54986/#review51650

This seems fine, but can you update the references in runtests [1] before landing?

[1] https://dxr.mozilla.org/mozilla-central/rev/829d3be6ba648b838ee1953fdfa1a477dace752f/testing/mochitest/runtests.py
Attachment #8756145 - Flags: review?(erahm)
Assignee: nobody → giles
Yes, and also in child process launch code (please apply over bug 1270752).  Probably overlook patches in bug 1248565 what all places need to be updated.
I've updated runtests.py. I don't see any MOZ_LOG_MODULES changes in the child process launch code in bug 1248565.
Comment on attachment 8756145 [details]
MozReview Request: Bug 1275439 - Switch debugging to MOZ_LOG. r?erahm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54986/diff/1-2/
Attachment #8756145 - Flags: review?(erahm)
Blocks: 1275744
Comment on attachment 8756145 [details]
MozReview Request: Bug 1275439 - Switch debugging to MOZ_LOG. r?erahm

https://reviewboard.mozilla.org/r/54986/#review52004

lgtm
Attachment #8756145 - Flags: review?(erahm) → review+
Thanks. Bug 1270752 hasn't landed yet, so better to do the fixup there.
https://hg.mozilla.org/mozilla-central/rev/35574c1aa969
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
See Also: → 1299713
You need to log in before you can comment on or make changes to this bug.