1275545 - Use Sereal for Cache::Memcached::Fast

Status: REOPENED

(bugzilla.mozilla.org :: General, task)

Description

[Dylan Hardison [:dylan] (he/him)]

Sereal is a lot faster than storable (which is what Cache::Memcached::Fast uses now). It is a pretty easy config change to add sereal support: 
pass (serialize_methods => [ $serialize_func, $deserialize_func ]) to Cache::Memcached::Fast.

Documentation for Cache::Memcached::Fast: https://metacpan.org/pod/Cache::Memcached::Fast

Here's an article about sereal: http://blog.booking.com/sereal-a-binary-data-serialization-format.html

In particular this graph is exciting:
http://blog.booking.com/static/sereal-a_binary_serialization_format/decoder_perf.png

Comment 1

[Issei Horie [:is2ei]]

Hello, I would like to work on this issue.
Could you please assign it to me?

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Sure thing! 

You can consult the readme (https://github.com/bugzilla/bugzilla/blob/master/README.rst)
and if you have other questions about setting up a dev server people will be available in #bugzilla on irc.mozilla.org

Comment 3

[Issei Horie [:is2ei]]

Attachment: patch.diff

Hi, I attached patch for bug #1275545.
Could you please review it?

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8826231 [details] [diff] [review]
patch.diff

Need to always enter a specific requestee for the review flag otherwise it will get lost.

dkl

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8826231 [details] [diff] [review]
patch.diff


This won't work, because you need:

use Sereal;

Probably near:
https://github.com/bugzilla/bugzilla/blob/master/Bugzilla/Memcached.pm#L18

Have you been able to get bugzilla running locally? we can chat about that in irc if you like, it isn't too difficult.

Comment 6

[Issei Horie [:is2ei]]

Attachment: patch.diff

Thanks for reviewing!
I attached new patch.diff.
It contains:

  use Serial;

This time I think I checked review flag and entered "[e-mail]" as requestee.
Could you please check it?

Comment 7

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8826687 [details] [diff] [review]
patch.diff

r=dylan

this works! Before we add it, we need to add the dependency to Makefile.PL.
It should be part of the optional memcached dependency.

https://github.com/bugzilla/bugzilla/blob/master/Makefile.PL#L149

Also, change the 'use Sereal' to 'require Sereal' and move it down to require Memcached::Fast'. Do this so that Sereal is only loaded when the memcached feature is available.

Comment 8

[nikshepsvn]

Is this open? Would love to finish it up!

Comment 9

[Dylan Hardison [:dylan] (he/him)]

It sure is! I'm moving this to BMO since we're going to be working on stabilizing that as Bugzilla 6.
BMO already depends on Sereal (as of the last week or so).

This will need local testing on a development VM -- see https://github.com/mozilla-bteam/bmo/blob/master/README.rst#using-vagrant-for-development and you can reach out to me on irc.mozilla.org #bugzilla with questions.

Comment 10

[Issei Horie [:is2ei]]

Hi, Is this still open?
Sorry for late but I'd like to finish this issue.

Comment 11

[Issei Horie [:is2ei]]

Attachment: patch-02.diff

Sorry for late.
Could you check this patch if it is still open?

Comment 12

[Issei Horie [:is2ei]]

I've created PR for this bug. https://github.com/bugzilla/bugzilla/pull/63
Could you check it when you have time? Thanks!

Comment 13

[Issei Horie [:is2ei]]

Hi Dylan,

I tried to run bmo repo on my local environment with vagrant.
Then, I got an error.

====================
$ vagrant up
Bringing machine 'db' up with 'virtualbox' provider...
Bringing machine 'web' up with 'virtualbox' provider...
==> db: Checking if box 'centos/6' is up to date...
==> db: Clearing any previously set network interfaces...
The specified host network collides with a non-hostonly network!
This will cause your specified IP to be inaccessible. Please change
the IP or name of your host only network so that it no longer matches that of
a bridged or non-hostonly network.

Bridged Network Address: '192.168.3.0'
Host-only Network 'enp2s0': '192.168.3.0'
========================

Could you help me to fix this issue, please?

Comment 14

[Issei Horie [:is2ei]]

Created PR in GitHub.
https://github.com/mozilla-bteam/bmo/pull/557

Comment 15

[Dylan Hardison [:dylan] (he/him)]

Hey, sorry. I'll review this now.

Comment 16

[Dylan Hardison [:dylan] (he/him)]

Re-opened, just briefly, as we have to do a push today and I didn't want to have to flush memcached. It'll go out next week.

Comment 17

[Firefox Bug Husbandry Bot]

Removing good-first-bug keyword because team does not have bandwidth to mentor at the moment.

Comment 18

[kumar.ishita]

Hi is this issue still open to contribute to ?

Comment 19

[Dylan Hardison [:dylan] (he/him)]

It's not a good first bug, sorry