1275622 - Artifact builds busted due to updater name change on OSX

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Stephen A Pohl [:spohl]]

I just heard on IRC that artifact builds appear to be busted after landing bug 394984. We had to change the updater binary name from "updater" to "org.mozilla.updater".

While I was typing this, Gijs pointed me to artifacts.py[1], which, sure enough, references the old updater name. Patch coming up.

[1] https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/artifacts.py#296

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Patch

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8756429 [details] [diff] [review]
Patch

Review of attachment 8756429 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Stephen!  I'm fine with this but going to redirect to chmanchester, who is much more involved in this right now.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8756429 [details] [diff] [review]
Patch

Review of attachment 8756429 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the patch. I don't have my macbook on hand to test, but looks good to me assuming it's seen some local testing.

Comment 4

[Robert Strong (they/them - no direct email)]

I'll land this on oak (where the updater work was tested) for verification.

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to oak
https://hg.mozilla.org/projects/oak/rev/c9e505ae0ba931ea3989607e3f337b0dbfb54a4f

Comment 6

[Robert Strong (they/them - no direct email)]

It doesn't look like this runs properly on project branches... can someone confirm?

Comment 7

[Chris Manchester (limited bugmail, email directly)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #6)
> It doesn't look like this runs properly on project branches... can someone
> confirm?

We only run the artifact builds in automation on Linux right now... the Linux artifact build on that push is failing for some reason, but for this fix I'll just verify it later tonight and land it if everything looks ok.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d36d2c80ed0

Comment 9

[Robert Strong (they/them - no direct email)]

(In reply to Chris Manchester (:chmanchester) from comment #7)
> (In reply to Robert Strong [:rstrong] (use needinfo to contact me) from
> comment #6)
> > It doesn't look like this runs properly on project branches... can someone
> > confirm?
> 
> We only run the artifact builds in automation on Linux right now... the
> Linux artifact build on that push is failing for some reason, but for this
> fix I'll just verify it later tonight and land it if everything looks ok.
For my own information, do these run on project branches? I went through treeherder for all of the project branches and only saw AB builds on oak Linux where it failed for me.

Comment 10

[Chris Manchester (limited bugmail, email directly)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #9)
> (In reply to Chris Manchester (:chmanchester) from comment #7)
> > (In reply to Robert Strong [:rstrong] (use needinfo to contact me) from
> > comment #6)
> > > It doesn't look like this runs properly on project branches... can someone
> > > confirm?
> > 
> > We only run the artifact builds in automation on Linux right now... the
> > Linux artifact build on that push is failing for some reason, but for this
> > fix I'll just verify it later tonight and land it if everything looks ok.
> For my own information, do these run on project branches? I went through
> treeherder for all of the project branches and only saw AB builds on oak
> Linux where it failed for me.

They're scheduled by a taskcluster definition in the tree, so perhaps some other project branches are too far behind trunk to have them (I notice them on elm though).

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3d36d2c80ed0