Closed Bug 1275622 Opened 4 years ago Closed 4 years ago

Artifact builds busted due to updater name change on OSX

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

Details

Attachments

(1 file)

I just heard on IRC that artifact builds appear to be busted after landing bug 394984. We had to change the updater binary name from "updater" to "org.mozilla.updater".

While I was typing this, Gijs pointed me to artifacts.py[1], which, sure enough, references the old updater name. Patch coming up.

[1] https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/artifacts.py#296
Attached patch PatchSplinter Review
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Attachment #8756429 - Flags: review?(nalexander)
Blocks: 394984
Comment on attachment 8756429 [details] [diff] [review]
Patch

Review of attachment 8756429 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Stephen!  I'm fine with this but going to redirect to chmanchester, who is much more involved in this right now.
Attachment #8756429 - Flags: review?(nalexander) → review?(cmanchester)
Blocks: 1275632
Comment on attachment 8756429 [details] [diff] [review]
Patch

Review of attachment 8756429 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the patch. I don't have my macbook on hand to test, but looks good to me assuming it's seen some local testing.
Attachment #8756429 - Flags: review?(cmanchester) → review+
No longer blocks: 1275632
I'll land this on oak (where the updater work was tested) for verification.
It doesn't look like this runs properly on project branches... can someone confirm?
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #6)
> It doesn't look like this runs properly on project branches... can someone
> confirm?

We only run the artifact builds in automation on Linux right now... the Linux artifact build on that push is failing for some reason, but for this fix I'll just verify it later tonight and land it if everything looks ok.
(In reply to Chris Manchester (:chmanchester) from comment #7)
> (In reply to Robert Strong [:rstrong] (use needinfo to contact me) from
> comment #6)
> > It doesn't look like this runs properly on project branches... can someone
> > confirm?
> 
> We only run the artifact builds in automation on Linux right now... the
> Linux artifact build on that push is failing for some reason, but for this
> fix I'll just verify it later tonight and land it if everything looks ok.
For my own information, do these run on project branches? I went through treeherder for all of the project branches and only saw AB builds on oak Linux where it failed for me.
Flags: needinfo?(cmanchester)
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #9)
> (In reply to Chris Manchester (:chmanchester) from comment #7)
> > (In reply to Robert Strong [:rstrong] (use needinfo to contact me) from
> > comment #6)
> > > It doesn't look like this runs properly on project branches... can someone
> > > confirm?
> > 
> > We only run the artifact builds in automation on Linux right now... the
> > Linux artifact build on that push is failing for some reason, but for this
> > fix I'll just verify it later tonight and land it if everything looks ok.
> For my own information, do these run on project branches? I went through
> treeherder for all of the project branches and only saw AB builds on oak
> Linux where it failed for me.

They're scheduled by a taskcluster definition in the tree, so perhaps some other project branches are too far behind trunk to have them (I notice them on elm though).
Flags: needinfo?(cmanchester)
https://hg.mozilla.org/mozilla-central/rev/3d36d2c80ed0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.