Closed
Bug 1275721
Opened 8 years ago
Closed 8 years ago
Remove --enable-android-resource-constrained, MOZ_ANDROID_RESOURCE_CONSTRAINED, & friends
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
All
Android
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: mcomella, Assigned: chmanchester)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We no longer support resource constrained builds (bug 1220184) but the build flags remain – let's remove them!
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → cmanchester
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/55304/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/55304/
Attachment #8756636 -
Flags: review?(mshal)
Comment 2•8 years ago
|
||
Comment on attachment 8756636 [details] MozReview Request: Bug 1275721 - Remove --enable-android-resource-constrained. r=mshal https://reviewboard.mozilla.org/r/55304/#review52220 Nice! Though it looks like mobile/android/base/Makefile.in still has a reference to MOZ_ANDROID_RESOURCE_CONSTRAINED that can go away (along with CONSTRAINED_AAPT_CONFIGURATIONS).
Attachment #8756636 -
Flags: review?(mshal)
Assignee | ||
Comment 3•8 years ago
|
||
https://reviewboard.mozilla.org/r/55304/#review52220 Thank you for noticing that!
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8756636 [details] MozReview Request: Bug 1275721 - Remove --enable-android-resource-constrained. r=mshal Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55304/diff/1-2/
Attachment #8756636 -
Flags: review?(mshal)
Comment 5•8 years ago
|
||
Comment on attachment 8756636 [details] MozReview Request: Bug 1275721 - Remove --enable-android-resource-constrained. r=mshal https://reviewboard.mozilla.org/r/55304/#review52276
Attachment #8756636 -
Flags: review?(mshal) → review+
Updated•8 years ago
|
Blocks: pyconfigure
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4a2403a44cd3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 49 → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•