Closed Bug 1275838 Opened 7 years ago Closed 7 years ago

Implement CustomElementsRegistry get function


(Core :: DOM: Core & HTML, defect, P2)




Tracking Status
firefox52 --- fixed


(Reporter: jdai, Assigned: jdai)



(Keywords: dev-doc-complete, Whiteboard: dom-ce-m1)


(1 file, 3 obsolete files)

According to session 4.13.4[1], we need to implement CustomElementsRegistry get function.

(I'm marking all the Custom Elements bugs as "backlog" but that's just to indicate they're not something we're fixing urgently and no comment on priority or anything.)
Whiteboard: btpp-backlog
Depends on: 1275833
Assignee: nobody → jdai
Depends on: 1275835
Attached patch wip, v1 (obsolete) — Splinter Review
Priority: -- → P2
Whiteboard: btpp-backlog → dom-ce-m1
Attachment #8773697 - Attachment is obsolete: true
Attachment #8789736 - Flags: feedback?(echen)
Comment on attachment 8789736 [details] [diff] [review]
Bug 1275838 - Implement CustomElementsRegistry get function.

Review of attachment 8789736 [details] [diff] [review]:

Attachment #8789736 - Flags: feedback?(echen) → feedback+
Attachment #8789736 - Flags: review?(wchen)
Attachment #8789736 - Flags: review?(wchen) → review+
Keywords: checkin-needed
need dom peer review: remote: WebIDL file dom/webidl/CustomElementsRegistry.webidl altered in changeset f0c053165318 without DOM peer review
Flags: needinfo?(jdai)
Keywords: checkin-needed
Comment on attachment 8791113 [details] [diff] [review]
Bug 1275838 - Implement CustomElementsRegistry get function. r=wchen

I forgot to ask DOM peer review. 
Hi Olli, 
Could you help to review my patch? Thank you.
Flags: needinfo?(jdai)
Attachment #8791113 - Flags: review+ → review?(bugs)
Comment on attachment 8791113 [details] [diff] [review]
Bug 1275838 - Implement CustomElementsRegistry get function. r=wchen

r+ for the .webidl
Attachment #8791113 - Flags: review?(bugs) → review+
Keywords: checkin-needed
Pushed by
Implement CustomElementsRegistry get function. r=smaug, r=wchen
Keywords: checkin-needed
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
I've made sure this method is documented:

I've also added a note to the Fx52 release notes:

Let me know if this is OK. Thanks!
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.