Implement CustomElementsRegistry get function

RESOLVED FIXED in Firefox 52

Status

()

P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jdai, Assigned: jdai)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla52
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: dom-ce-m1)

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

2 years ago
According to session 4.13.4[1], we need to implement CustomElementsRegistry get function.


[1] https://html.spec.whatwg.org/multipage/scripting.html#dom-customelementsregistry-get
(I'm marking all the Custom Elements bugs as "backlog" but that's just to indicate they're not something we're fixing urgently and no comment on priority or anything.)
Whiteboard: btpp-backlog

Updated

2 years ago
Depends on: 1275833
(Assignee)

Updated

2 years ago
Assignee: nobody → jdai
Depends on: 1275835
(Assignee)

Comment 2

2 years ago
Created attachment 8773697 [details] [diff] [review]
wip, v1

Updated

2 years ago
Priority: -- → P2
Whiteboard: btpp-backlog → dom-ce-m1
(Assignee)

Comment 3

2 years ago
Created attachment 8789736 [details] [diff] [review]
Bug 1275838 - Implement CustomElementsRegistry get function.
Attachment #8773697 - Attachment is obsolete: true
Attachment #8789736 - Flags: feedback?(echen)

Comment 4

2 years ago
Comment on attachment 8789736 [details] [diff] [review]
Bug 1275838 - Implement CustomElementsRegistry get function.

Review of attachment 8789736 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8789736 - Flags: feedback?(echen) → feedback+
(Assignee)

Updated

2 years ago
Attachment #8789736 - Flags: review?(wchen)

Updated

2 years ago
Attachment #8789736 - Flags: review?(wchen) → review+
(Assignee)

Comment 5

2 years ago
Created attachment 8791113 [details] [diff] [review]
Bug 1275838 - Implement CustomElementsRegistry get function. r=wchen

Try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6c22adf7c6163b8be7f9574f1b0d015efe20816&filter-tier=1
Attachment #8789736 - Attachment is obsolete: true
Attachment #8791113 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
need dom peer review: remote: WebIDL file dom/webidl/CustomElementsRegistry.webidl altered in changeset f0c053165318 without DOM peer review
Flags: needinfo?(jdai)
Keywords: checkin-needed
(Assignee)

Comment 7

2 years ago
Comment on attachment 8791113 [details] [diff] [review]
Bug 1275838 - Implement CustomElementsRegistry get function. r=wchen

I forgot to ask DOM peer review. 
Hi Olli, 
Could you help to review my patch? Thank you.
Flags: needinfo?(jdai)
Attachment #8791113 - Flags: review+ → review?(bugs)

Comment 8

2 years ago
Comment on attachment 8791113 [details] [diff] [review]
Bug 1275838 - Implement CustomElementsRegistry get function. r=wchen

r+ for the .webidl
Attachment #8791113 - Flags: review?(bugs) → review+
(Assignee)

Comment 9

2 years ago
Created attachment 8793602 [details] [diff] [review]
Bug 1275838 - Implement CustomElementsRegistry get function. r=smaug, wchen
Attachment #8791113 - Attachment is obsolete: true
Attachment #8793602 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 10

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2d8c1189368
Implement CustomElementsRegistry get function. r=smaug, r=wchen
Keywords: checkin-needed

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a2d8c1189368
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Keywords: dev-doc-needed
I've made sure this method is documented:
https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry/get

I've also added a note to the Fx52 release notes: 
https://developer.mozilla.org/en-US/Firefox/Releases/52#DOM_HTML_DOM

Let me know if this is OK. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.