1275891 - Consider making "Highlight all" the default state of the find toolbar

Status: NEW

(Toolkit :: Find Toolbar, defect)

Description

[Jonathan Kingston [:jkt] he/him]

When I type a search into the page the first result is highlighted, I need to explicitly hit the "Highlight All" button or Alt or Ctrl+A to get all results.

Chrome, Opera, Safari and Edge all highlight all by default and don't offer an option to do this.

Could we remove the button and change it to always highlight? Is there a specific rationale this is a button?

This could be a preference perhaps to experiment?

Comment 1

[Mike de Boer [:mikedeboer]]

This is being worked on in bug 384458. Please follow along there!

Comment 2

[Jonathan Kingston [:jkt] he/him]

Woo, Thanks Mike! Sorry I missed that work.

Comment 3

[B.J. Herbison]

Unfortunately the fix for bug 384458 ruined highlight all. Try, the entries are highlighted at first, but if you scroll the page the dimming effect and the highlight all goes away.

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to B.J. Herbison from comment #3)
> Unfortunately the fix for bug 384458 ruined highlight all. Try, the entries
> are highlighted at first, but if you scroll the page the dimming effect and
> the highlight all goes away.

It shouldn't disappear on scroll, only on a click in the page... Which method are you using to scroll the page? It might simply be a bug in the implementation, so please label it a failure right away before I've got a chance to fix it.

Comment 5

[Mike de Boer [:mikedeboer]]

(In reply to Mike de Boer [:mikedeboer] from comment #4)
> It might simply be a bug in the
> implementation, so please label it a failure right away before I've got a
> chance to fix it.

*please don't

Comment 6

[B.J. Herbison]

I opened a ticket on the problem, bug 1279683.

I was scrolling the page by clicking in the scroll bar.

(Sometimes page-up and page-down don't work when focus is in the find bar. There's probably a bug to report there, but I didn't realize it works sometimes until I just tried it.)

> It shouldn't disappear on scroll, only on a click in the page... 

Um, my regular workflow depends on the highlight all results being preserved when I click in the page. I want to be able to open links in new windows and highlight text while still seeing the results of my last Find.