Closed Bug 1275903 Opened 6 years ago Closed 6 years ago

Add tests for the log slice API & switch to using requests

Categories

(Tree Management :: Treeherder: API, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: wlach)

References

Details

Attachments

(1 file)

To help avoid eg bug 1275796.
I'll take this.
Assignee: nobody → wlachance
Comment on attachment 8756943 [details] [review]
[treeherder] wlach:1275903 > mozilla:master

This doesn't cover everything, but should have caught the last few problems we ran into.

Bonus: it replaces some use of urllib2 with requests. :)
Attachment #8756943 - Flags: review?(emorley)
Comment on attachment 8756943 [details] [review]
[treeherder] wlach:1275903 > mozilla:master

Thank you for this! Also great to remove more of urllib2 :-)
Attachment #8756943 - Flags: review?(emorley) → review+
Blocks: 1165356
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1277499
Summary: Add tests for the log slice API → Add tests for the log slice API & switch to using requests
You need to log in before you can comment on or make changes to this bug.