1275796 - Logviewer says that every log "no longer exists or has expired"

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Phil Ringnalda (:philor)]

e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=28723188&repo=mozilla-inbound#L1628 from about three hours ago, though the same is true of the very most recent failed run, or one from Tuesday, or staging: "The log no longer exists or has expired."

Comment 1

[Ed Morley [:emorley]]

Bug 1273231 performed a schema change. As part of that landing, incoming logs are saved to a new table, and a migration script was run to move over old rows. I suspect that script just hadn't finished running when you checked, since the link in comment 0 now works for me. 

Will, do you know what time the script finished running? :-)

Sorry if this caused disruption - another time we'll try to give you a bit more heads up.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I can see the same for https://treeherder.allizom.org/logviewer.html#?job_id=3582563&repo=mozilla-central#L873

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh, maybe a dupe of bug 1271763?

Comment 4

[Ed Morley [:emorley]]

Possibly.

Similar to that bug, the STR were incomplete (hence the WFM above). See bug 1271763 comment 2.

The key part is to click a log step top right, to try and load the log. The page (and the error summary) loads fine.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Not for me. Steps:

1. https://treeherder.allizom.org/#/jobs?repo=mozilla-central&fromchange=2afd8fa9bb5df5577e5566468bb423b76c63cc77&filter-searchStr=fxfn&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=3582563
2. Click the logviewer button at the lower left
3. Click the single step

The log is still not available.

Comment 6

[Ed Morley [:emorley]]

No I mean:

STR in both bugs implied the problem was that the log viewer couldn't find the job/error summary etc. Which is why I said WFM.

More complete STR (linked above) show what the actual problem is, and yes I see that problem too.

Comment 7

[William Lachance (:wlach)]

(In reply to Ed Morley [:emorley] from comment #1)
> Bug 1273231 performed a schema change. As part of that landing, incoming
> logs are saved to a new table, and a migration script was run to move over
> old rows. I suspect that script just hadn't finished running when you
> checked, since the link in comment 0 now works for me. 
> 
> Will, do you know what time the script finished running? :-)
> 
> Sorry if this caused disruption - another time we'll try to give you a bit
> more heads up.

The migration actually completed before I switched things over with minimal disruption, but it looks like this is another problem with the logslice API that I missed.

Comment 8

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1275796 > mozilla:master

Comment 9

[William Lachance (:wlach)]

Comment on attachment 8756846 [details] [review]
[treeherder] wlach:1275796 > mozilla:master

Sorry for the trouble, I should have tested this more thoroughly.

Comment 10

[Ed Morley [:emorley]]

Comment on attachment 8756846 [details] [review]
[treeherder] wlach:1275796 > mozilla:master

Have filed bug 1275903 for adding tests for the log slice API, since we've never had any.

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla/treeherder/commit/dc3c65545a61100c4efd79be5a31309000eef174

Comment 12

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e643a90282840f491803a1781e479974e7c4c089
Bug 1275796 - Update logslice API to use new job log ORM class

Comment 13

[Phil Ringnalda (:philor)]

Ah, the failure in my STR was a failure to realize that we stick the unworkable second hash onto a URL that we've loaded without it. Click a failed job, click the icon for the log, you load https://treeherder.mozilla.org/logviewer.html#?job_id=28771245&repo=mozilla-inbound which shows the "no longer exists or has expired" but by the time you copy it, the URL has been changed to https://treeherder.mozilla.org/logviewer.html#?job_id=28771245&repo=mozilla-inbound#L3942 which when loaded does not.

Comment 14

[Ed Morley [:emorley]]

Ah yes I had the same confusion in bug 1271763 comment 1.

I've filed bug 1275909 for fixing the log viewer line anchors to avoid that problem.

Comment 15

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/34b9c631cfa9edef01492dcfc7be2bddbe13ee15
Bug 1275796 - Travis: Revert change to apt-get command

One instance was fixed after review comments, this changes the other.

Comment 16

[Ed Morley [:emorley]]

Bah that was meant to be bug 1275425.

Comment 17

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1275796-2 > mozilla:master

Comment 18

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5870b1d49556b410c25b8c38da8ef713ed9408aa
Bug 1275796 - Fix logslice API with taskcluster logs

Taskcluster logs use the name 'builds-4h'

https://github.com/mozilla/treeherder/commit/2d711b5dbbb75e7aa7d16ee6f3e50772bf28e833
Merge pull request #1520 from wlach/1275796-2

Bug 1275796 - Fix logslice API with taskcluster logs