1276389 - Remove esr38 from the buildbot configs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove esr38 from buildbot-configs

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove esr38 from tools

grep says I've gotten all esr38 references, but I'm getting errors when I run list_builder_differences.sh for reasons I can't fathom.

2016-05-27 19:30:34,455 - Couldn't load test-output/bm81-build_scheduler/master.cfg
Traceback (most recent call last):
  File "/home/ryanvm/.mozilla/releng/repos/braindump/buildbot-related/dump_master_json.py", line 111, in dump_master
    c = loadMaster(path)
  File "/home/ryanvm/.mozilla/releng/repos/braindump/buildbot-related/dump_master_json.py", line 26, in loadMaster
    execfile(path, g, g)
  File "/home/ryanvm/.mozilla/releng/repos/buildbot-configs/test-output/bm81-build_scheduler/master.cfg", line 110, in <module>
    execfile(releaseConfigFile, releaseBranchConfig, releaseBranchConfig)
IOError: [Errno 2] No such file or directory: 'release-thunderbird-comm-esr38.py'

Comment 3

[Rail Aliiev [:rail]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)
> Created attachment 8757530 [details] [diff] [review]
> remove esr38 from tools
> 
> grep says I've gotten all esr38 references, but I'm getting errors when I
> run list_builder_differences.sh for reasons I can't fathom.
> 
> 2016-05-27 19:30:34,455 - Couldn't load
> test-output/bm81-build_scheduler/master.cfg
> Traceback (most recent call last):
>   File
> "/home/ryanvm/.mozilla/releng/repos/braindump/buildbot-related/
> dump_master_json.py", line 111, in dump_master
>     c = loadMaster(path)
>   File
> "/home/ryanvm/.mozilla/releng/repos/braindump/buildbot-related/
> dump_master_json.py", line 26, in loadMaster
>     execfile(path, g, g)
>   File
> "/home/ryanvm/.mozilla/releng/repos/buildbot-configs/test-output/bm81-
> build_scheduler/master.cfg", line 110, in <module>
>     execfile(releaseConfigFile, releaseBranchConfig, releaseBranchConfig)
> IOError: [Errno 2] No such file or directory:
> 'release-thunderbird-comm-esr38.py'

I think this is because it uses unmodified tools repo, where esr38 is enabled on some masters. If we land the tools patch it should just work

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8757530 [details] [diff] [review]
remove esr38 from tools

https://hg.mozilla.org/build/tools/rev/5ebdd8b4cab5

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8757529 [details] [diff] [review]
remove esr38 from buildbot-configs

https://hg.mozilla.org/build/buildbot-configs/rev/1831040dc4bf

Comment 6

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/1831040dc4bf

Comment 7

[Rail Aliiev [:rail]]

Thank you for the patches Ryan!

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

I used Fabric to run 'make update' on the build masters, and also scheduler (manually), since they were failing checkconfig after the landings here. The automated reconfig script doesn't update the master_config.json --> bug 1277116.

Comment 9

[Rail Aliiev [:rail]]

fix up: https://hg.mozilla.org/build/tools/rev/9b0658fa7382