1277116 - maybe_reconfig.sh doesn't update master_config.json

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Bug 1276389 removed the esr38 branches, and the symlinks were removed on the masters, but maybe_reconfig doesn't update <master>/master/master_config.json. The build masters and scheduler then fail to reconfig with
 IOError: [Errno 2] No such file or directory: 'release-thunderbird-comm-esr38.py'

See also bug 1215294.

Comment 1

[Andrei Obreja [:aobreja NOT AVAILABLE][:buildduty]]

Attachment: patch_bug1277116_tools.patch

This patch update master_config.json but only if the master is enable.
The command that is run for  maybe_reconfig.sh is bellow:

./maybe_reconfig.sh /builds/buildbot/tests1-windows/ 2>&1 | logger -t maybe_reconfig.sh


The tests that were made on buildbot-master69.bb.releng.use1.mozilla.com were successfully,bellow is a sample of these tests:

2016-06-23 06:47:59 - INFO  -  Begin updating master_config.json
writing new master_config.json file to /builds/buildbot/tests1-windows//master/master_config.json
2016-06-23 06:47:59 - INFO  - Reconfig completed successfuly. - 1466689662
2016-06-23 06:47:59 - INFO  - Elapsed: 0h 0m 17s

Comment 2

[Kim Moir [:kmoir] ET]

Why is PRODUCTION_MASTERS_URL included in the patch and specific to windows?

Comment 3

[Andrei Obreja [:aobreja NOT AVAILABLE][:buildduty]]

I wanted to use PRODUCTION_MASTERS_URL in the script like this in the first place: 
python ./buildbot-configs/update-master-json.py "${PRODUCTION_MASTERS_URL}"{MASTER_DIR}/master/master_config.json >> ${LOGFILE} 2>&1, based on how the script from fabric actions.py was first created.

Indeed for this script this part is useless so I will add another patch that will not include this part.

Comment 4

[Andrei Obreja [:aobreja NOT AVAILABLE][:buildduty]]

Attachment: patch_bug1277116_tools.patch

Comment 5

[Kim Moir [:kmoir] ET]

Comment on attachment 8764858 [details] [diff] [review]
patch_bug1277116_tools.patch

shouldn't you update the master_config.json before you reconfig?  Because the reconfig will will take that file into account

Comment 6

[Andrei Obreja [:aobreja NOT AVAILABLE][:buildduty]]

Attachment: patch_bug1277116_tools.patch

I have attached the latest patch which make the update of master_config.json before reconfig.

Comment 7

[Kim Moir [:kmoir] ET]

Andrei you can verify that this is working by looking at the timestamp of master_config.json on a build master and then closing this bug.  The change went into a reconfig yesterday.

Comment 8

[Andrei Obreja [:aobreja NOT AVAILABLE][:buildduty]]

Everything seems fine after verifying timestamp of master_config.json and the logs from reconfig.log. Master_config.json has been successfully recreated.