1276560 - Package hyphenation-dictionaries separately for reftests

Assignee

Description

•

10 years ago

This is an intermediate step for Bug 1095719. In Bug 1095719 we'll download hyphenation-dictionaries at runtime. we won’t be able to do this when running reftests. We need to package them separately and install them along with the build.

k.krish

Assignee

Updated

•

10 years ago

Assignee: nobody → k.krish

Sebastian Kaspari (:sebastian; :pocmo)

Updated

•

10 years ago

Blocks: downloadable-hyphenation-dicts

k.krish

Assignee

Comment 2

•

10 years ago

k.krish

Assignee

Comment 3

•

10 years ago

When we exclude the hyphenation dictionaries from the build, many reftests will fail. To stop them from failing we have to package the hyphenation-dictionary separately. We should get all the *.dic files and load in it to the device at runtime. As a first step we have to package the hyphenations-dictionary separately and push it to the profile directory. References taken from Bug1197716 and Bug877203 To test I created a directory mobile/android/hyphenation and dumped all the dictionary files. I code to include the files in the temporary profile directory and push it to -sdcard/tests/reftest/profile I am able see the hyphenation dictionaries end up in sdcard/tests/reftest/profile/hyphenation/<files> By doing this we have successfully packaged the hyphenation separately. Unfortunately This does not solve the problem. The reftests fail even after pushing these files to profile directory. The problem is “Gecko” does not load the hyphenation dictionaries from the profile directory. The Hyphenation dictionaries are loaded in nsHyphenationManager.cpp http://mxr.mozilla.org/mozilla-central/source/intl/hyphenation/nsHyphenationManager.cpp I have included a sample code to make gecko look for hyphenation dictionaries from profile directory too. nsHyphenationManager.cpp > > nsCOMPtr<nsIFile> profileDir; > rv = NS_GetSpecialDirectory(NS_APP_USER_PROFILE_LOCAL_50_DIR, > getter_AddRefs(profileDir)); > if (NS_SUCCEEDED(rv)) { > profileDir->AppendNative(NS_LITERAL_CSTRING("hyphenation")); > LoadPatternListFromDir(profileDir); > } > Now the hyphenation dictionary is being loaded from the sdcard/tests/reftest/profile/ directory and the reftests are passing. Sample changeset https://hg.mozilla.org/try/rev/a701a7b3f4bda097732142a6f8f278e43be261d9 Try results https://treeherder.mozilla.org/#/jobs?repo=try&revision=956609c4d8f0

k.krish

Assignee

Updated

•

10 years ago

Depends on: 1280757

k.krish

Assignee

Comment 4

•

10 years ago

Attached file Bug1276560 Package hyphenation-dictionaries separately for reftests — Details

Review commit: https://reviewboard.mozilla.org/r/61936/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/61936/

Attachment #8767465 - Flags: review?(s.kaspari)

k.krish

Assignee

Updated

•

10 years ago

Attachment #8767465 - Flags: review?(gbrown)

k.krish

Assignee

Comment 5

•

10 years ago

Try Results https://treeherder.mozilla.org/#/jobs?repo=try&revision=374316725536 The reftests will pass after the code for Bug 1280757 is merged.

Sebastian Kaspari (:sebastian; :pocmo)

Comment 6

•

10 years ago

Comment on attachment 8767465 [details] Bug1276560 Package hyphenation-dictionaries separately for reftests https://reviewboard.mozilla.org/r/61936/#review58762 r+ with the changes: ::: layout/tools/reftest/mach_commands.py:234 (Diff revision 1) > + for (dirpath, dirnames, filenames) in os.walk(hyphenation_path): > + for hyphenation_file in filenames: > + if hyphenation_file.endswith('.dic'): nit: The name 'hyphenation_file' is a bit misleading because it's just a file and only after the next check you know if it's a hyphenation dictionary. Maybe use just filename? ::: mobile/android/confvars.sh:28 (Diff revision 1) > +MOZ_EXCLUDE_HYPHENATION_DICTIONARIES=1 > + This should not be part of this patch. This is the last step after landing and testing everything related. :)

Attachment #8767465 - Flags: review?(s.kaspari) → review+

Geoff Brown [:gbrown]

Comment 7

•

10 years ago

Comment on attachment 8767465 [details] Bug1276560 Package hyphenation-dictionaries separately for reftests https://reviewboard.mozilla.org/r/61936/#review58852

Attachment #8767465 - Flags: review?(gbrown) → review+

k.krish

Assignee

Comment 8

•

10 years ago

Comment on attachment 8767465 [details] Bug1276560 Package hyphenation-dictionaries separately for reftests Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61936/diff/1-2/

Attachment #8767465 - Flags: review+

k.krish

Assignee

Comment 9

•

10 years ago

https://reviewboard.mozilla.org/r/61936/#review58762 > nit: The name 'hyphenation_file' is a bit misleading because it's just a file and only after the next check you know if it's a hyphenation dictionary. Maybe use just filename? Yeah. Makes much sense :). My bad. Changed the name accordingly > This should not be part of this patch. This is the last step after landing and testing everything related. :) Removed the flag.

k.krish

Assignee

Updated

•

10 years ago

Keywords: checkin-needed

Pulsebot

Comment 10

•

10 years ago

Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/d28a755c4014 Package hyphenation-dictionaries separately for reftests. r=sebastian

Keywords: checkin-needed

Carsten Book [:Tomcat]

Comment 11

•

10 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/d28a755c4014

Status: NEW → RESOLVED

Closed: 10 years ago

status-firefox50: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 50

Sebastian Kaspari (:sebastian; :pocmo)

Updated

•

9 years ago

Depends on: 1335429

Nobody; OK to take it and work on it

Updated

•

5 years ago

Product: Firefox for Android → Firefox for Android Graveyard

Bugzilla

Package hyphenation-dictionaries separately for reftests

Categories

(Firefox for Android Graveyard :: General, defect)

Tracking

(firefox50 fixed)

People

(Reporter: k.krish, Assigned: k.krish)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Updated

Updated

Comment 2

Comment 3

Updated

Comment 4

Updated

Comment 5

Comment 6

Comment 7

Comment 8

Comment 9

Updated

Comment 10

Comment 11

Updated

Updated

Attachment

General

Description

File Name

Content Type