Closed Bug 1276732 Opened 4 years ago Closed 4 years ago

WebGL blocklist failure ids are masked by ANGLE init failure id

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: jrmuizel, Assigned: BenWa)

References

Details

Attachments

(1 file)

eg.
{'adapter': {u'GPUActive': True,
   u'description': u'Intel(R)  946GZ Express Chipset Family',
   u'deviceID': u'0x2972',
   u'driver': u'igxprd32',
   u'driverDate': u'12-12-2008',
   u'driverVersion': u'6.14.10.5016',
   u'subsysID': u'101517aa',
   u'vendorID': u'0x8086'},
  'clientId': u'07dd371f-ec15-49dd-9342-ad9dcedf2030',
  'driverVersion': [6, 14, 10, 5016],
  'environment/build/version': u'49.0a1',
  'environment/system/gfx/adapters': [{u'GPUActive': True,
    u'description': u'Intel(R)  946GZ Express Chipset Family',
    u'deviceID': u'0x2972',
    u'driver': u'igxprd32',
    u'driverDate': u'12-12-2008',
    u'driverVersion': u'6.14.10.5016',
    u'subsysID': u'101517aa',
    u'vendorID': u'0x8086'}],
  'environment/system/gfx/features': {u'compositor': u'basic',
   u'd2d': {u'failureId': u'FEATURE_FAILURE_DL_BLACKLIST_g984',
    u'status': u'unavailable',
    u'version': u'1.1'},
   u'd3d11': {u'failureId': u'FEATURE_FAILURE_INTEL_5',
    u'status': u'blacklisted'},
   u'opengl': {u'failureId': u'FEATURE_FAILURE_INTEL_5'},
   u'webgl': {u'failureId': u'FEATURE_FAILURE_INTEL_5'}},
  'environment/system/os/name': u'Windows_NT',
  'environment/system/os/servicePackMajor': 3,
  'environment/system/os/servicePackMinor': 0,
  'environment/system/os/version': u'5.1',
  'features': {u'compositor': u'basic',
   u'd2d': {u'failureId': u'FEATURE_FAILURE_DL_BLACKLIST_g984',
    u'status': u'unavailable',
    u'version': u'1.1'},
   u'd3d11': {u'failureId': u'FEATURE_FAILURE_INTEL_5',
    u'status': u'blacklisted'},
   u'opengl': {u'failureId': u'FEATURE_FAILURE_INTEL_5'},
   u'webgl': {u'failureId': u'FEATURE_FAILURE_INTEL_5'}},
  'gen': u'gen4',
  'payload/keyedHistograms/CANVAS_WEBGL_FAILURE_ID': {u'FEATURE_FAILURE_WEBGL_ANGLE_INIT': 12L}}
Assignee: nobody → bgirard
Flags: needinfo?(bgirard)
Blocks: 1259536
Attachment #8759851 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

https://reviewboard.mozilla.org/r/57690/#review54540
Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/1-2/
Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/2-3/
Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/3-4/
Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/4-5/
Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/5-6/
Pushed by b56girard@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4264b01fd313
Report the GLContext error to WebGL for telemetry. r=jrmuizel
Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/6-7/
Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/7-8/
Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/8-9/
Pushed by b56girard@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c605b6253cdb
Report the GLContext error to WebGL for telemetry. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/c605b6253cdb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Approval Request Comment
[User impact if declined]: Without this, we won't have good WebGL telemetry on Aurora
[Describe test coverage new/current, TreeHerder]: very little
[Risks and why]: There should be no functionality change outside of recorded telemetry
Attachment #8759851 - Flags: approval-mozilla-aurora?
Was going to request, thanks!
Flags: needinfo?(bgirard)
Depends on: 1279317
Please use pointers for outvars in the future.
Marking aurora as affected based on the request....
Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

We want accurate telemetry, let's uplift!
Attachment #8759851 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.