1276732 - WebGL blocklist failure ids are masked by ANGLE init failure id

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

eg.
{'adapter': {u'GPUActive': True,
   u'description': u'Intel(R)  946GZ Express Chipset Family',
   u'deviceID': u'0x2972',
   u'driver': u'igxprd32',
   u'driverDate': u'12-12-2008',
   u'driverVersion': u'6.14.10.5016',
   u'subsysID': u'101517aa',
   u'vendorID': u'0x8086'},
  'clientId': u'07dd371f-ec15-49dd-9342-ad9dcedf2030',
  'driverVersion': [6, 14, 10, 5016],
  'environment/build/version': u'49.0a1',
  'environment/system/gfx/adapters': [{u'GPUActive': True,
    u'description': u'Intel(R)  946GZ Express Chipset Family',
    u'deviceID': u'0x2972',
    u'driver': u'igxprd32',
    u'driverDate': u'12-12-2008',
    u'driverVersion': u'6.14.10.5016',
    u'subsysID': u'101517aa',
    u'vendorID': u'0x8086'}],
  'environment/system/gfx/features': {u'compositor': u'basic',
   u'd2d': {u'failureId': u'FEATURE_FAILURE_DL_BLACKLIST_g984',
    u'status': u'unavailable',
    u'version': u'1.1'},
   u'd3d11': {u'failureId': u'FEATURE_FAILURE_INTEL_5',
    u'status': u'blacklisted'},
   u'opengl': {u'failureId': u'FEATURE_FAILURE_INTEL_5'},
   u'webgl': {u'failureId': u'FEATURE_FAILURE_INTEL_5'}},
  'environment/system/os/name': u'Windows_NT',
  'environment/system/os/servicePackMajor': 3,
  'environment/system/os/servicePackMinor': 0,
  'environment/system/os/version': u'5.1',
  'features': {u'compositor': u'basic',
   u'd2d': {u'failureId': u'FEATURE_FAILURE_DL_BLACKLIST_g984',
    u'status': u'unavailable',
    u'version': u'1.1'},
   u'd3d11': {u'failureId': u'FEATURE_FAILURE_INTEL_5',
    u'status': u'blacklisted'},
   u'opengl': {u'failureId': u'FEATURE_FAILURE_INTEL_5'},
   u'webgl': {u'failureId': u'FEATURE_FAILURE_INTEL_5'}},
  'gen': u'gen4',
  'payload/keyedHistograms/CANVAS_WEBGL_FAILURE_ID': {u'FEATURE_FAILURE_WEBGL_ANGLE_INIT': 12L}}

Comment 1

[Benoit Girard (:BenWa)]

Attachment: Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review commit: https://reviewboard.mozilla.org/r/57690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57690/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

https://reviewboard.mozilla.org/r/57690/#review54540

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/1-2/

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/2-3/

Comment 5

[Jeff Muizelaar [:jrmuizel]]

https://reviewboard.mozilla.org/r/57690/#review54622

Comment 6

[Benoit Girard (:BenWa)]

Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/3-4/

Comment 7

[Benoit Girard (:BenWa)]

Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/4-5/

Comment 8

[Benoit Girard (:BenWa)]

Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/5-6/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4264b01fd313
Report the GLContext error to WebGL for telemetry. r=jrmuizel

Comment 10

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f99522f6c95162da9c76ae1d773a90dcebbeacf8
Backed out changeset 4264b01fd313 (Bug 1276732) for causing build bustage

Comment 11

[Benoit Girard (:BenWa)]

Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/6-7/

Comment 12

[Benoit Girard (:BenWa)]

Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/7-8/

Comment 13

[Benoit Girard (:BenWa)]

Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57690/diff/8-9/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c605b6253cdb
Report the GLContext error to WebGL for telemetry. r=jrmuizel

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c605b6253cdb

Comment 16

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

Approval Request Comment
[User impact if declined]: Without this, we won't have good WebGL telemetry on Aurora
[Describe test coverage new/current, TreeHerder]: very little
[Risks and why]: There should be no functionality change outside of recorded telemetry

Comment 17

[Benoit Girard (:BenWa)]

Was going to request, thanks!

Comment 18

[Kelsey Gilbert [:jgilbert]]

Please use pointers for outvars in the future.

Comment 19

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Marking aurora as affected based on the request....

Comment 20

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8759851 [details]
Bug 1276732 - Report the GLContext error to WebGL for telemetry.

We want accurate telemetry, let's uplift!

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c0ead5950258e5a5db6e4bd9a0714b500b780d8d