Closed
Bug 1279317
Opened 8 years ago
Closed 8 years ago
FEATURE_FAILURE_WEBGL_ANGLE_INIT overrides more specific failure ids
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla50
People
(Reporter: BenWa, Unassigned)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
jrmuizel
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
Bug 1276732 propagated the value they are still being overwritten.
Reporter | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/58860/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58860/
Attachment #8761771 -
Flags: review?(jmuizelaar)
Updated•8 years ago
|
Attachment #8761771 -
Flags: review?(jmuizelaar) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8761771 [details] Bug 1279317 - Don't override the failureId with a more general one. https://reviewboard.mozilla.org/r/58860/#review55742
Pushed by b56girard@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b6d3c35e1494 Don't override the failureId with a more general one. r=jrmuizel
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8761771 [details] Bug 1279317 - Don't override the failureId with a more general one. Approval Request Comment [User impact if declined]: Without this, we won't have good WebGL telemetry on Aurora [Describe test coverage new/current, TreeHerder]: very little [Risks and why]: There should be no functionality change outside of recorded telemetry
Attachment #8761771 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
Whiteboard: [gfx-noted]
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b6d3c35e1494
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment 6•8 years ago
|
||
Comment on attachment 8761771 [details] Bug 1279317 - Don't override the failureId with a more general one. Telemetry fix, ok to uplift to aurora
Attachment #8761771 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/6ed3514f726d
status-firefox49:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•