Remove prefixed -moz-text-align-last

RESOLVED FIXED in Firefox 53

Status

()

defect
P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: xidorn, Assigned: bmo)

Tracking

(Blocks 1 bug, {dev-doc-complete, site-compat})

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(2 attachments)

Reporter

Description

3 years ago
Given that Blink never ships a prefixed text-align-last, it doesn't seem to be risky for us to remove the prefixed property. But it's probably still worth waiting for a while.

Comment 1

3 years ago
Would it still be too early to consider removing -moz-test-align-last?

(I don't see any mention of it on fxsitecompat.com, but I'm not sure if advance notice there is necessary before we remove this.)
Flags: needinfo?(xidorn+moz)
Reporter

Comment 2

3 years ago
fxsitecompat.com has mentioned that -moz-text-align-last will be removed in near future in the post about unprefixing text-align-last [1].

As I mentioned in comment 0, given Blink never ships prefixed version of this property, any site depends on the prefixed version of this property should always be broken on Blink-based browsers.


[1] https://www.fxsitecompat.com/en-CA/docs/2016/text-align-last-has-been-unprefixed/
Flags: needinfo?(xidorn+moz)
Assignee

Updated

3 years ago
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

3 years ago
Assignee: nobody → aschen
Status: NEW → ASSIGNED
Assignee

Updated

3 years ago
Attachment #8813642 - Flags: review?(xidorn+moz)
Attachment #8813643 - Flags: review?(ttromey)
Reporter

Comment 5

3 years ago
mozreview-review
Comment on attachment 8813642 [details]
Bug 1276808 - Remove -moz-text-align-last property.

https://reviewboard.mozilla.org/r/95066/#review95224
Attachment #8813642 - Flags: review?(xidorn+moz) → review+

Comment 6

3 years ago
mozreview-review
Comment on attachment 8813643 [details]
Bug 1276808 - Update DevTool properties-db.js file.

https://reviewboard.mozilla.org/r/95068/#review96020

Sorry about the delay -- there was a US holiday last week.
Thank you for the patch.  It looks good.

At first I was thrown off by some of the other changes, but then I tried ./mach devtools-css-db locally and realized that it must not have been run after some other changes here.  So, all it
Attachment #8813643 - Flags: review?(ttromey) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Comment 9

3 years ago
(In reply to Tom Tromey :tromey from comment #6)
> Sorry about the delay -- there was a US holiday last week.
> Thank you for the patch.  It looks good.

Thanks for your review.

TRY:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=83189e99d07b782ff48ced3a0bec95d581e28464
Assignee

Comment 10

3 years ago
Try looks good.

TY, highfive! Pls help to review and push for me.
Thanks.
Flags: needinfo?(tlin)
Reporter

Comment 11

3 years ago
Pushed the button.
Flags: needinfo?(tlin)

Comment 12

3 years ago
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8954c0c7bc5
Remove -moz-text-align-last property. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/e31d2408a313
Update DevTool properties-db.js file. r=tromey

Comment 14

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a8954c0c7bc5
https://hg.mozilla.org/mozilla-central/rev/e31d2408a313
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.