1276808 - Remove prefixed -moz-text-align-last

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Xidorn Quan [:xidorn] UTC+10]

Given that Blink never ships a prefixed text-align-last, it doesn't seem to be risky for us to remove the prefixed property. But it's probably still worth waiting for a while.

Comment 1

[Thomas Wisniewski]

Would it still be too early to consider removing -moz-test-align-last?

(I don't see any mention of it on fxsitecompat.com, but I'm not sure if advance notice there is necessary before we remove this.)

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

fxsitecompat.com has mentioned that -moz-text-align-last will be removed in near future in the post about unprefixing text-align-last [1].

As I mentioned in comment 0, given Blink never ships prefixed version of this property, any site depends on the prefixed version of this property should always be broken on Blink-based browsers.


[1] https://www.fxsitecompat.com/en-CA/docs/2016/text-align-last-has-been-unprefixed/

Comment 3

[Astley Chen (inactive)]

Attachment: Bug 1276808 - Remove -moz-text-align-last property.

Review commit: https://reviewboard.mozilla.org/r/95066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95066/

Comment 4

[Astley Chen (inactive)]

Attachment: Bug 1276808 - Update DevTool properties-db.js file.

Review commit: https://reviewboard.mozilla.org/r/95068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95068/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8813642 [details]
Bug 1276808 - Remove -moz-text-align-last property.

https://reviewboard.mozilla.org/r/95066/#review95224

Comment 6

[Tom Tromey :tromey]

Comment on attachment 8813643 [details]
Bug 1276808 - Update DevTool properties-db.js file.

https://reviewboard.mozilla.org/r/95068/#review96020

Sorry about the delay -- there was a US holiday last week.
Thank you for the patch.  It looks good.

At first I was thrown off by some of the other changes, but then I tried ./mach devtools-css-db locally and realized that it must not have been run after some other changes here.  So, all it

Comment 7

[Astley Chen (inactive)]

Comment on attachment 8813642 [details]
Bug 1276808 - Remove -moz-text-align-last property.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/95066/diff/1-2/

Comment 8

[Astley Chen (inactive)]

Comment on attachment 8813643 [details]
Bug 1276808 - Update DevTool properties-db.js file.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/95068/diff/1-2/

Comment 9

[Astley Chen (inactive)]

(In reply to Tom Tromey :tromey from comment #6)
> Sorry about the delay -- there was a US holiday last week.
> Thank you for the patch.  It looks good.

Thanks for your review.

TRY:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=83189e99d07b782ff48ced3a0bec95d581e28464

Comment 10

[Astley Chen (inactive)]

Try looks good.

TY, highfive! Pls help to review and push for me.
Thanks.

Comment 11

[Xidorn Quan [:xidorn] UTC+10]

Pushed the button.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8954c0c7bc5
Remove -moz-text-align-last property. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/e31d2408a313
Update DevTool properties-db.js file. r=tromey

Comment 13

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/moz-text-align-last-property-has-been-removed/ (I pushed the button too.)

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a8954c0c7bc5
https://hg.mozilla.org/mozilla-central/rev/e31d2408a313

Comment 15

[Sebastian Zartner [:sebo]]

Mentioned this at https://developer.mozilla.org/en-US/docs/Web/CSS/text-align-last#Browser_compatibility and https://developer.mozilla.org/en-US/Firefox/Releases/53.

Sebastian