Closed Bug 1039541 Opened 6 years ago Closed 4 years ago

Unprefix -moz-text-align-last

Categories

(Core :: CSS Parsing and Computation, defect)

30 Branch
x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: brandon, Assigned: xidorn)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-complete, site-compat, Whiteboard: [parity-blink])

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140608211622

Steps to reproduce:

Added `text-align-last:justify` to an element.


Actual results:

`text-align-last` was discarded. `-moz-text-align-last` works.


Expected results:

`text-align-last` should be accepted like `-moz-text-align-last`.

Spec: http://www.w3.org/TR/css-text-3/#text-align-last-property

Last change to `text-align-last` was in the latest version (10 October 2013).

One issue regarding `text-align-last`: http://www.w3.org/Style/CSS/Tracker/issues/333

Side note: Gmail discards `-moz-text-align-last` in emails, but keeps `text-align-last`.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [parity-blink][parity-edge]
So it seems we pass all tests in CSSWG on text-align-last if we unprefix it.
Could you (1) send an intent to ship and (2) file a bug to remove the alias?

(I think shipping unprefixed seems reasonable if that's what blink and edge have done (which your whiteboard annotation makes me suspect) or if it's in a CR draft (which I'm not sure of).)
caniuse.com says Edge and even IE does, but it seems it is wrong. According to my test, Blink indeed has shipped unprefixed text-align-last, but Edge doesn't.
Whiteboard: [parity-blink][parity-edge] → [parity-blink]
Comment on attachment 8757164 [details]
MozReview Request: Bug 1039541 part 1 - Unprefix text-align-last. r?heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55742/diff/1-2/
Comment on attachment 8757165 [details]
MozReview Request: Bug 1039541 part 2 - Use unprefixed text-align-last in tests. r?heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55744/diff/1-2/
Comment on attachment 8757164 [details]
MozReview Request: Bug 1039541 part 1 - Unprefix text-align-last. r?heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55742/diff/2-3/
Comment on attachment 8757165 [details]
MozReview Request: Bug 1039541 part 2 - Use unprefixed text-align-last in tests. r?heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55744/diff/2-3/
Keywords: site-compat
(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #5)
> caniuse.com says Edge and even IE does, but it seems it is wrong. According
> to my test, Blink indeed has shipped unprefixed text-align-last, but Edge
> doesn't.

Maybe file an issue at https://github.com/Fyrd/caniuse/issues ?
Attachment #8757164 - Flags: review?(cam) → review+
Comment on attachment 8757164 [details]
MozReview Request: Bug 1039541 part 1 - Unprefix text-align-last. r?heycam

https://reviewboard.mozilla.org/r/55742/#review52778
Comment on attachment 8757165 [details]
MozReview Request: Bug 1039541 part 2 - Use unprefixed text-align-last in tests. r?heycam

https://reviewboard.mozilla.org/r/55744/#review52780
Attachment #8757165 - Flags: review?(cam) → review+
Assignee: nobody → bugzilla
https://hg.mozilla.org/mozilla-central/rev/16f29c411ce6
https://hg.mozilla.org/mozilla-central/rev/cec360c7fbc9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Blocks: 1276808
Thanks percyley!
You need to log in before you can comment on or make changes to this bug.