1039541 - Unprefix -moz-text-align-last

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Brandon Frohs]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140608211622

Steps to reproduce:

Added `text-align-last:justify` to an element.


Actual results:

`text-align-last` was discarded. `-moz-text-align-last` works.


Expected results:

`text-align-last` should be accepted like `-moz-text-align-last`.

Spec: http://www.w3.org/TR/css-text-3/#text-align-last-property

Last change to `text-align-last` was in the latest version (10 October 2013).

One issue regarding `text-align-last`: http://www.w3.org/Style/CSS/Tracker/issues/333

Side note: Gmail discards `-moz-text-align-last` in emails, but keeps `text-align-last`.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

So it seems we pass all tests in CSSWG on text-align-last if we unprefix it.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1039541 part 1 - Unprefix text-align-last. r?heycam

Review commit: https://reviewboard.mozilla.org/r/55742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55742/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1039541 part 2 - Use unprefixed text-align-last in tests. r?heycam

Review commit: https://reviewboard.mozilla.org/r/55744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55744/

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Could you (1) send an intent to ship and (2) file a bug to remove the alias?

(I think shipping unprefixed seems reasonable if that's what blink and edge have done (which your whiteboard annotation makes me suspect) or if it's in a CR draft (which I'm not sure of).)

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

caniuse.com says Edge and even IE does, but it seems it is wrong. According to my test, Blink indeed has shipped unprefixed text-align-last, but Edge doesn't.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8757164 [details]
MozReview Request: Bug 1039541 part 1 - Unprefix text-align-last. r?heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55742/diff/1-2/

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8757165 [details]
MozReview Request: Bug 1039541 part 2 - Use unprefixed text-align-last in tests. r?heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55744/diff/1-2/

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Intent to ship: https://groups.google.com/d/msg/mozilla.dev.platform/jbMO8mkFZwE/ATXLMHECPAAJ

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8757164 [details]
MozReview Request: Bug 1039541 part 1 - Unprefix text-align-last. r?heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55742/diff/2-3/

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8757165 [details]
MozReview Request: Bug 1039541 part 2 - Use unprefixed text-align-last in tests. r?heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55744/diff/2-3/

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #5)
> caniuse.com says Edge and even IE does, but it seems it is wrong. According
> to my test, Blink indeed has shipped unprefixed text-align-last, but Edge
> doesn't.

Maybe file an issue at https://github.com/Fyrd/caniuse/issues ?

Comment 12

[Cameron McCormack (:heycam)]

Comment on attachment 8757164 [details]
MozReview Request: Bug 1039541 part 1 - Unprefix text-align-last. r?heycam

https://reviewboard.mozilla.org/r/55742/#review52778

Comment 13

[Cameron McCormack (:heycam)]

Comment on attachment 8757165 [details]
MozReview Request: Bug 1039541 part 2 - Use unprefixed text-align-last in tests. r?heycam

https://reviewboard.mozilla.org/r/55744/#review52780

Comment 14

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16f29c411ce6a378f4456cd97c9221d5e797f063
Bug 1039541 part 1 - Unprefix text-align-last. r=heycam

https://hg.mozilla.org/integration/mozilla-inbound/rev/cec360c7fbc9a75c86fa88f342743e59a8468915
Bug 1039541 part 2 - Use unprefixed text-align-last in tests. r=heycam

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/16f29c411ce6
https://hg.mozilla.org/mozilla-central/rev/cec360c7fbc9

Comment 16

[Kohei Yoshino [:kohei]]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/text-align-last-has-been-unprefixed/

Comment 17

[yisibl]

Update:

https://developer.mozilla.org/en-US/docs/Web/CSS/text-align-last#Browser_compatibility
https://developer.mozilla.org/en-US/Firefox/Releases/49#CSS

Comment 18

[Jean-Yves Perrier [:teoli]]

Thanks percyley!