Integrate scan-build with Taskcluster

RESOLVED FIXED

Status

NSS
Test
RESOLVED FIXED
2 years ago
9 months ago

People

(Reporter: ttaubert, Assigned: fkiefer)

Tracking

(Depends on: 1 bug)

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Similar to clang-format, we should automatically run scan-build on check-in.
(Reporter)

Updated

a year ago
Depends on: 1256171, 1256169, 1284489
(Reporter)

Comment 1

a year ago
Let's start with a scan-build task that looks for reports in lib/ssl/ files.
Summary: Integrate scan-build with Taskcluster → Integrate scan-build for lib/ssl with Taskcluster
(Reporter)

Updated

a year ago
Assignee: nobody → franziskuskiefer
Status: NEW → ASSIGNED
Created attachment 8768364 [details] [diff] [review]
scan-build-tc.patch

scan-build on lib/ssl and lib/freebl with non-fatal error messages.
Attachment #8768364 - Flags: review?(ttaubert)
(Reporter)

Comment 3

a year ago
Comment on attachment 8768364 [details] [diff] [review]
scan-build-tc.patch

Review of attachment 8768364 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet.

::: automation/taskcluster/graph/tools/scan-build.yml
@@ +41,5 @@
> +        build:
> +          platform: nss-tools
> +        machine:
> +          platform: nss-tools
> +        symbol: scan-build

Should we rename the symbol and the task itself to scan-build-3.8 ? Makes it immediately clear which version of scan-build is running. We're doing the same for clang-format.
Attachment #8768364 - Flags: review?(ttaubert) → review+
(Reporter)

Updated

a year ago
Summary: Integrate scan-build for lib/ssl with Taskcluster → Integrate scan-build with Taskcluster
https://hg.mozilla.org/projects/nss/rev/bfdbb92d5d01
Keywords: leave-open
(Reporter)

Comment 5

a year ago
Created attachment 8768781 [details] [diff] [review]
0001-Bug-1277228-Create-a-tools-_build_base.yml-to-share-.patch

Let's have a _base_build.yml file, shared between the tools tasks.

https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=46a430afcb2e9ff7eca766794e3d35d838753e00&selectedJob=3074
Attachment #8768781 - Flags: review?(franziskuskiefer)
Attachment #8768781 - Flags: review?(franziskuskiefer) → review+
(Reporter)

Comment 6

a year ago
https://hg.mozilla.org/projects/nss/rev/6ddb391c1eab
Created attachment 8769834 [details] [diff] [review]
fatal-freebl-scanbuild.patch

this makes freebl scan-build failures fatal
Attachment #8769834 - Flags: review?(ttaubert)
(Reporter)

Updated

a year ago
Attachment #8769834 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/projects/nss/rev/1f512e08ec1d
(Reporter)

Comment 9

a year ago
Let's call this fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Keywords: leave-open
Resolution: --- → FIXED
(Reporter)

Comment 10

a year ago
https://hg.mozilla.org/projects/nss/rev/54b9d0655e6b
Depends on: 1308204
Depends on: 1308401
added  base, certdb, and certhigh
https://hg.mozilla.org/projects/nss/rev/25bbb8bdd46086979558331d5030adeab4d4129e
added ckfw, crmf, cryptohi, nss, and dev
https://hg.mozilla.org/projects/nss/rev/39f61839fbf49fb7d17f3da6843b7e8d9e2c3b67

Updated

9 months ago
Blocks: 1340222
You need to log in before you can comment on or make changes to this bug.