Closed
Bug 1277228
Opened 6 years ago
Closed 6 years ago
Integrate scan-build with Taskcluster
Categories
(NSS :: Test, defect)
NSS
Test
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ttaubert, Assigned: franziskus)
References
(Depends on 1 open bug)
Details
Attachments
(3 files)
2.72 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
3.50 KB,
patch
|
franziskus
:
review+
|
Details | Diff | Splinter Review |
1.36 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
Similar to clang-format, we should automatically run scan-build on check-in.
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 1•6 years ago
|
||
Let's start with a scan-build task that looks for reports in lib/ssl/ files.
Summary: Integrate scan-build with Taskcluster → Integrate scan-build for lib/ssl with Taskcluster
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → franziskuskiefer
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
scan-build on lib/ssl and lib/freebl with non-fatal error messages.
Attachment #8768364 -
Flags: review?(ttaubert)
Reporter | ||
Comment 3•6 years ago
|
||
Comment on attachment 8768364 [details] [diff] [review] scan-build-tc.patch Review of attachment 8768364 [details] [diff] [review]: ----------------------------------------------------------------- Sweet. ::: automation/taskcluster/graph/tools/scan-build.yml @@ +41,5 @@ > + build: > + platform: nss-tools > + machine: > + platform: nss-tools > + symbol: scan-build Should we rename the symbol and the task itself to scan-build-3.8 ? Makes it immediately clear which version of scan-build is running. We're doing the same for clang-format.
Attachment #8768364 -
Flags: review?(ttaubert) → review+
Reporter | ||
Updated•6 years ago
|
Summary: Integrate scan-build for lib/ssl with Taskcluster → Integrate scan-build with Taskcluster
Assignee | ||
Comment 4•6 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/bfdbb92d5d01
Assignee | ||
Updated•6 years ago
|
Keywords: leave-open
Reporter | ||
Comment 5•6 years ago
|
||
Let's have a _base_build.yml file, shared between the tools tasks. https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=46a430afcb2e9ff7eca766794e3d35d838753e00&selectedJob=3074
Attachment #8768781 -
Flags: review?(franziskuskiefer)
Assignee | ||
Updated•6 years ago
|
Attachment #8768781 -
Flags: review?(franziskuskiefer) → review+
Reporter | ||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/6ddb391c1eab
Assignee | ||
Comment 7•6 years ago
|
||
this makes freebl scan-build failures fatal
Attachment #8769834 -
Flags: review?(ttaubert)
Reporter | ||
Updated•6 years ago
|
Attachment #8769834 -
Flags: review?(ttaubert) → review+
Assignee | ||
Comment 8•6 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/1f512e08ec1d
Reporter | ||
Comment 9•6 years ago
|
||
Let's call this fixed.
Reporter | ||
Comment 10•6 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/54b9d0655e6b
Assignee | ||
Comment 11•6 years ago
|
||
added base, certdb, and certhigh https://hg.mozilla.org/projects/nss/rev/25bbb8bdd46086979558331d5030adeab4d4129e
Assignee | ||
Comment 12•6 years ago
|
||
added ckfw, crmf, cryptohi, nss, and dev https://hg.mozilla.org/projects/nss/rev/39f61839fbf49fb7d17f3da6843b7e8d9e2c3b67
You need to log in
before you can comment on or make changes to this bug.
Description
•