Integrate scan-build with Taskcluster

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: ttaubert, Assigned: franziskus)

Tracking

(Depends on: 1 bug)

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Similar to clang-format, we should automatically run scan-build on check-in.
(Reporter)

Updated

3 years ago
Depends on: 1256171, 1256169, 1284489
Let's start with a scan-build task that looks for reports in lib/ssl/ files.
Summary: Integrate scan-build with Taskcluster → Integrate scan-build for lib/ssl with Taskcluster
(Reporter)

Updated

3 years ago
Assignee: nobody → franziskuskiefer
Status: NEW → ASSIGNED
Created attachment 8768364 [details] [diff] [review]
scan-build-tc.patch

scan-build on lib/ssl and lib/freebl with non-fatal error messages.
Attachment #8768364 - Flags: review?(ttaubert)
Comment on attachment 8768364 [details] [diff] [review]
scan-build-tc.patch

Review of attachment 8768364 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet.

::: automation/taskcluster/graph/tools/scan-build.yml
@@ +41,5 @@
> +        build:
> +          platform: nss-tools
> +        machine:
> +          platform: nss-tools
> +        symbol: scan-build

Should we rename the symbol and the task itself to scan-build-3.8 ? Makes it immediately clear which version of scan-build is running. We're doing the same for clang-format.
Attachment #8768364 - Flags: review?(ttaubert) → review+
(Reporter)

Updated

3 years ago
Summary: Integrate scan-build for lib/ssl with Taskcluster → Integrate scan-build with Taskcluster
Keywords: leave-open
Created attachment 8768781 [details] [diff] [review]
0001-Bug-1277228-Create-a-tools-_build_base.yml-to-share-.patch

Let's have a _base_build.yml file, shared between the tools tasks.

https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=46a430afcb2e9ff7eca766794e3d35d838753e00&selectedJob=3074
Attachment #8768781 - Flags: review?(franziskuskiefer)
Attachment #8768781 - Flags: review?(franziskuskiefer) → review+
Created attachment 8769834 [details] [diff] [review]
fatal-freebl-scanbuild.patch

this makes freebl scan-build failures fatal
Attachment #8769834 - Flags: review?(ttaubert)
(Reporter)

Updated

3 years ago
Attachment #8769834 - Flags: review?(ttaubert) → review+
Let's call this fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: leave-open
Resolution: --- → FIXED

Updated

2 years ago
Blocks: 1340222
You need to log in before you can comment on or make changes to this bug.