Closed Bug 1277228 Opened 4 years ago Closed 4 years ago

Integrate scan-build with Taskcluster

Categories

(NSS :: Test, defect)

Product:
NSS
Component:
Test
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ttaubert, Assigned: franziskus)

References

(Depends on 1 open bug)

Details

Attachments

(3 files)

scan-build-tc.patch
2.72 KB, patch
ttaubert
: review+
Details | Diff | Splinter Review
0001-Bug-1277228-Create-a-tools-_build_base.yml-to-share-.patch
3.50 KB, patch
franziskus
: review+
Details | Diff | Splinter Review
fatal-freebl-scanbuild.patch
1.36 KB, patch
ttaubert
: review+
Details | Diff | Splinter Review 
Similar to clang-format, we should automatically run scan-build on check-in.
Depends on: 1256171, 1256169, 1284489
Let's start with a scan-build task that looks for reports in lib/ssl/ files.
Summary: Integrate scan-build with Taskcluster → Integrate scan-build for lib/ssl with Taskcluster
Assignee: nobody → franziskuskiefer
Status: NEW → ASSIGNED
scan-build on lib/ssl and lib/freebl with non-fatal error messages.
Attachment #8768364 - Flags: review?(ttaubert)
Comment on attachment 8768364 [details] [diff] [review]
scan-build-tc.patch

Review of attachment 8768364 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet.

::: automation/taskcluster/graph/tools/scan-build.yml
@@ +41,5 @@
> +        build:
> +          platform: nss-tools
> +        machine:
> +          platform: nss-tools
> +        symbol: scan-build

Should we rename the symbol and the task itself to scan-build-3.8 ? Makes it immediately clear which version of scan-build is running. We're doing the same for clang-format.
Attachment #8768364 - Flags: review?(ttaubert) → review+
Summary: Integrate scan-build for lib/ssl with Taskcluster → Integrate scan-build with Taskcluster
Keywords: leave-open
Attachment #8768781 - Flags: review?(franziskuskiefer) → review+
this makes freebl scan-build failures fatal
Attachment #8769834 - Flags: review?(ttaubert)
Attachment #8769834 - Flags: review?(ttaubert) → review+
Let's call this fixed.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: leave-open
Resolution: --- → FIXED
Depends on: 1308204
Depends on: 1308401
Blocks: 1340222
You need to log in before you can comment on or make changes to this bug.