Closed Bug 1277775 Opened 4 years ago Closed 3 years ago

Remove MOZ_CONSTEXPR{,_VAR,_TMPL} and use constexpr directly

Categories

(Core :: MFBT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- affected
firefox50 --- fixed

People

(Reporter: xidorn, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The versions of GCC and Clang we use have already supported constexpr for quite a while. As soon as VS2013 support is dropped, we can use constexpr directly, and do not need the macro anymore.
I have a WIP patch for this bug.
Assignee: nobody → cpeterson
Now that we have dropped support for VS2013 (bug 1186064) for VS2015, all our officially-supported compilers support constexpr. We can replace MFBT's MOZ_CONSTEXPR{_VAR,_TMPL} macros with constexpr.
Attachment #8769050 - Flags: review?(nfroyd)
Comment on attachment 8769050 [details] [diff] [review]
use-constexpr.patch

Review of attachment 8769050 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming it all compiles.
Attachment #8769050 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] [away 9 July through 20 July] from comment #3)
> r=me assuming it all compiles.

Thanks. Yes, it all compiles and passes Try. :)
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96875d7ae6f2
Replace MOZ_CONSTEXPR{_VAR,_TMPL} with constexpr. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/96875d7ae6f2
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Blocks: 1243617
You need to log in before you can comment on or make changes to this bug.