Remove MOZ_CONSTEXPR{,_VAR,_TMPL} and use constexpr directly

RESOLVED FIXED in Firefox 50

Status

()

Core
MFBT
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: xidorn, Assigned: cpeterson)

Tracking

(Blocks: 1 bug)

Trunk
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 affected, firefox50 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The versions of GCC and Clang we use have already supported constexpr for quite a while. As soon as VS2013 support is dropped, we can use constexpr directly, and do not need the macro anymore.
(Assignee)

Comment 1

2 years ago
I have a WIP patch for this bug.
Assignee: nobody → cpeterson
status-firefox50: --- → affected
(Assignee)

Updated

2 years ago
(Assignee)

Comment 2

2 years ago
Created attachment 8769050 [details] [diff] [review]
use-constexpr.patch

Now that we have dropped support for VS2013 (bug 1186064) for VS2015, all our officially-supported compilers support constexpr. We can replace MFBT's MOZ_CONSTEXPR{_VAR,_TMPL} macros with constexpr.
Attachment #8769050 - Flags: review?(nfroyd)
Comment on attachment 8769050 [details] [diff] [review]
use-constexpr.patch

Review of attachment 8769050 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming it all compiles.
Attachment #8769050 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 4

2 years ago
(In reply to Nathan Froyd [:froydnj] [away 9 July through 20 July] from comment #3)
> r=me assuming it all compiles.

Thanks. Yes, it all compiles and passes Try. :)

Comment 5

2 years ago
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96875d7ae6f2
Replace MOZ_CONSTEXPR{_VAR,_TMPL} with constexpr. r=froydnj

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/96875d7ae6f2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
(Assignee)

Updated

2 years ago
Blocks: 1243617
You need to log in before you can comment on or make changes to this bug.