888493 - add MOZ_CONSTEXPR_VAR

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Trevor Saunders (:tbsaunde)]

Some compilers don't like things like
static const constexpr foo = bar;
other compilers don't support constexpr at all so we don't want to just do
static MOZ_CONSTEXPR foo = bar;
so lets add MOZ_CONSTEXPR_VAR that is constexpr if that is supported and otherwise const.

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: bug 888493 - add MOZ_CONSTEXPR_VAR and use it in jsrc/ion/ some

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 769193 [details] [diff] [review]
bug 888493 - add MOZ_CONSTEXPR_VAR and use it in jsrc/ion/ some

Review of attachment 769193 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/Attributes.h
@@ +129,3 @@
>  #else
>  #  define MOZ_CONSTEXPR         /* no support */
> +#  define MOZ_CONSTEXPR_VAR         const

Since everything else here is aligned, keep the const/constexpr aligned with the constexpr/no-support comment above each.

Comment 3

[Trevor Saunders (:tbsaunde)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/454706720bbc

Comment 4

[Phil Ringnalda (:philor)]

Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/7d6d824067ea

https://tbpl.mozilla.org/php/getParsedLog.php?id=24946713&tree=Mozilla-Inbound if you like it Linux-flavored, https://tbpl.mozilla.org/php/getParsedLog.php?id=24946587&tree=Mozilla-Inbound if you like it Windows flavored, everyone agreed that they had no idea what MOZ_THIS_IN_INITIALIZER_LIST you were talking about.

Comment 5

[Trevor Saunders (:tbsaunde)]

it looks like somehow a hunk remove the this initializer think magically appeared in the patch!?! so I removed that and pushed again
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/040df3280d8c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/040df3280d8c