1277863 - Add crash signature field for "External Software Affecting Firefox" product

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task)

Description

[[:philipp]]

it would be nice to have the ability to attach crash signatures to bugs filed under the "External Software Affecting Firefox" product, since quite a number of these external issues cause us to crash unfortunately.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

This is a regression from bug 1267785, "Plugins" had the crash sig field enabled.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1277863_2.patch

Added the new product name to $cf_visibile_in_products, and I also added a sanity check for this.

sanity checks take a really long time to run, so I added a switch to only run the sanity checks from hooks...

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8759771 [details] [diff] [review]
1277863_2.patch

Review of attachment 8759771 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl with nits on check in.

::: extensions/BMO/Extension.pm
@@ +966,5 @@
>  }
>  
> +sub sanitycheck_check {
> +    my ($self, $args) = @_;
> +    

whitespace in 3 places

::: sanitycheck.cgi
@@ +387,3 @@
>  Bugzilla::Hook::process('sanitycheck_repair', { status => \&Status });
>  
> +goto hooks if $hooks_only;

nit: add newline

@@ +930,4 @@
>  ###########################################################################
>  # Check hook
>  ###########################################################################
> +hooks:

nit: rename to check_hooks and add newline above and below.

Comment 4

[David Lawrence [:dkl]]

(In reply to David Lawrence [:dkl] from comment #3)
> Comment on attachment 8759771 [details] [diff] [review]
> 1277863_2.patch
> 
> Review of attachment 8759771 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=dkl with nits on check in.

Oh and go ahead and remove the missing products (or figure out what they changed to) from Data.pm if you feel like.

dkl

Comment 5

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   20bc492..13161f4  master -> master

up-cased and renamed the labels. I believe all uppercase is conventional.