Closed Bug 1278127 Opened 4 years ago Closed 4 years ago

The font picker in Thunderbird's compose window has font names needlessly indented

Categories

(Thunderbird :: Message Compose Window, defect, minor)

All
Linux
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 50.0

People

(Reporter: aceman, Assigned: Paenglab)

References

Details

(Keywords: polish)

Attachments

(1 file, 2 obsolete files)

The id=FontFaceSelect menulist in the compose window has a menupopup with font names available. On Linux, these font names are indented, but there is no icon or checkmark preceding the names that would use the space. On Windows they are not indented. On OS X there supposedly is a checkmark showing which font is being used.

I think either remove the indent or use it for a checkmark also on linux.
Attached patch bug1278127.patch (obsolete) — Splinter Review
First I tried to hide the .menu-iconic-left for all class="noIconPopup" popups, but the folderpane-mode-selector-menulist shows a radio button on Linux. So I had to hide them only for the #FontFacePopup.
Attachment #8760093 - Flags: review?(acelists)
(In reply to Richard Marti (:Paenglab) from comment #1)
> First I tried to hide the .menu-iconic-left for all class="noIconPopup"
> popups, but the folderpane-mode-selector-menulist shows a radio button on
> Linux.

Then why is it marked noIconPopup if it has "icons" (needs space for the radio marker) ?
Because the menuitem[type="radio"] isn't defined on Windows like on Linux
https://dxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/linux/global/menu.css#179
and is empty.
Seems to also be the case for #viewPicker. On Linux it has bullet before the chosen item, in Windows there is none (even no space). But in the submenus of e.g. Format menu in Compose window, there are bullets even on Windows. Is there some rule to that? That menus can have bullets, but menupopups can't?

Can you see on OS X/Linux if the useRadios attribute on FontFacePopup is set to true? On Windows it is false.
Attached patch bug1278127.patch v2 (obsolete) — Splinter Review
Removed a not used selector.
Attachment #8760093 - Attachment is obsolete: true
Attachment #8760093 - Flags: review?(acelists)
Attachment #8760397 - Flags: review?(acelists)
Same patch as v2 but applied on top of bug 1268520. Depending when the other bug lands this or the other patch are valid.
Attachment #8760401 - Flags: review?(acelists)
Comment on attachment 8760401 [details] [diff] [review]
bug1278127.patch v2.1

Review of attachment 8760401 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. I will land this with 31ch changed to 35ch as requested in the other bug.
Attachment #8760401 - Flags: review?(acelists) → review+
Attachment #8760397 - Attachment is obsolete: true
Attachment #8760397 - Flags: review?(acelists)
https://hg.mozilla.org/comm-central/rev/7f87bea3b1e86129ac84b72e4ba31c46a06327e6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
Blocks: 1278489
You need to log in before you can comment on or make changes to this bug.