1278205 - [Presentation WebAPI] enable Presentation API via preference instead of permission

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: [WIP] allow-presentation-in-web-page.patch

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=659321526841

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: [WIP] allow-presentation-in-web-page.patch

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: [WIP] allow-presentation-in-web-page.patch

Comment 5

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: Bug 1278205 - use preference for exposing presentation API. .

Review commit: https://reviewboard.mozilla.org/r/71514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71514/

Comment 6

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8781009 [details]
Bug 1278205 - use preference for exposing presentation API. .

summary of this change:
1. remove |presentation| permission
2. use |dom.presentation.enabled| for API that is common for both controller and receiver
3. use |dom.presentation.controller.enabled| for API that is only for controller.
4. use |dom.presentation.receiver.enabled| for API that is only for receiver.

Comment 7

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8781009 [details]
Bug 1278205 - use preference for exposing presentation API. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/71514/diff/1-2/

Comment 8

[Olli Pettay [:smaug]]

So dom.presentation.enabled needs to be enabled before dom.presentation.controller.enabled or dom.presentation.receiver.enabled can enable certain parts of the API?

Comment 9

[Olli Pettay [:smaug]]

Comment on attachment 8781009 [details]
Bug 1278205 - use preference for exposing presentation API. .

https://reviewboard.mozilla.org/r/71514/#review69214

Ah, this way. And yes, the spec seem to hint that some interfaces are exposed only in some contexts.

Comment 10

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

(In reply to Olli Pettay [:smaug] from comment #8)
> So dom.presentation.enabled needs to be enabled before
> dom.presentation.controller.enabled or dom.presentation.receiver.enabled can
> enable certain parts of the API?

Yes, unfortunately we need to fiddle two preferences for controller and receiver, three preferences for 1-UA device since it supports both APIs.

Comment 11

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8781009 [details]
Bug 1278205 - use preference for exposing presentation API. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/71514/diff/2-3/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f9021b0c901
use preference for exposing presentation API. r=smaug.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5f9021b0c901

Comment 14

[Florian Scholz (Open Web Docs)]

The compat data on these pages now show the preference info:

https://developer.mozilla.org/en-US/docs/Web/API/Presentation
https://developer.mozilla.org/en-US/docs/Web/API/Presentation/defaultRequest
https://developer.mozilla.org/en-US/docs/Web/API/Presentation/receiver

https://developer.mozilla.org/en-US/docs/Web/API/PresentationAvailability
https://developer.mozilla.org/en-US/docs/Web/API/PresentationAvailability/value
https://developer.mozilla.org/en-US/docs/Web/API/PresentationAvailability/onchange

https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnection
https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnection/binaryType
https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnection/close
https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnection/id
https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnection/send
https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnection/state
https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnection/terminate
https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnection/url

https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnectionAvailableEvent
https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnectionAvailableEvent/PresentationConnectionAvailableEvent
https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnectionAvailableEvent/connection

https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnectionCloseEvent
https://developer.mozilla.org/en-US/docs/Web/API/PresentationConnectionList
https://developer.mozilla.org/en-US/docs/Web/API/PresentationReceiver

https://developer.mozilla.org/en-US/docs/Web/API/PresentationRequest
https://developer.mozilla.org/en-US/docs/Web/API/PresentationRequest/PresentationRequest
https://developer.mozilla.org/en-US/docs/Web/API/PresentationRequest/getAvailability
https://developer.mozilla.org/en-US/docs/Web/API/PresentationRequest/onconnectionavailable
https://developer.mozilla.org/en-US/docs/Web/API/PresentationRequest/reconnect
https://developer.mozilla.org/en-US/docs/Web/API/PresentationRequest/start