1278254 - [hang][e10s] Print > PDF > Open PDF in Preview hangs on Mac

Status: RESOLVED WORKSFORME

(Core :: Print Preview, defect, P3)

Description

[Jonathan Watt [:jwatt]]

Print as PDF on Mac hangs after asserting:

###!!! ASSERTION: Deallocator for PPrintProgressDialogChild should not be called on nsPrintingProxy.: 'Not Reached', file embedding/components/printingui/ipc/nsPrintingProxy.cpp

Comment 1

[Jonathan Watt [:jwatt]]

I also see:

JavaScript error: chrome://global/content/browser-content.js, line 659: TypeError: printSettings is null

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: stack for hang

Comment 3

[Jonathan Watt [:jwatt]]

(The assert and hang are both in the child process.)

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: Console output from debug build

Comment 5

[Jonathan Watt [:jwatt]]

The hang only seems to happen specifically when going through File > Print > PDF > Open PDF in Preview. The assertions still happen when opening the print dialog and when saving as a PDF file though.

Comment 6

[Jim Mathies [:jimm]]

Bob, any thoughts here?

Comment 7

[Bob Owen (:bobowen)]

That assertion just looks wrong to me, I think the dealloc function gets called either way.
The PrintProgressDialogChild that we create "manually" in ShowProgress gets NS_ADDREF-ed once or twice depending on whether it's passed back for both return params.
They should be holding it for as long as IPC wants it, but I think we should be adding a reference for IPC as well and releasing in the dealloc.

Jonathan - does the hang and or null error still happen if you remove that assertion?
If it does this is probably two separate bugs, could you file one of them separately please.

Also, I'm guessing File > Print > PDF > Open PDF in Preview is an OS X thing, so I may have trouble reproducing, but I'll see if I can work out why the settings might be null.

Comment 8

[Jonathan Watt [:jwatt]]

Yeah, the assertions seem to be separate. See the bugs that I just opened and added to this bug's "See Also" field.

Comment 9

[Jim Mathies [:jimm]]

Tracy, would you please try to reproduce the hang here.

Comment 10

[Jonathan Watt [:jwatt]]

The SVG I first encountered this on:

https://bugzilla.mozilla.org/attachment.cgi?id=8760283

Comment 11

[Jonathan Watt [:jwatt]]

Although this hang occurs on things as simple as data:text/html,hi

Comment 12

[Tracy Walker [:tracy]]

Unable to reproduce, using the test samples in comments 10 and 11. In both cases with File > Print, I see:

[Exception... "Component returned failure code: 0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED) [nsIPrintSettingsService.defaultPrinterName]"  nsresult: "0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED)"  location: "JS frame :: chrome://global/content/browser-content.js :: getPrintSettings :: line 482"  data: no]       (unknown)

then continuing, > PDF > Open PDF in Preview I see.
TypeError: printSettings is null      browser-content.js:659:1

Same result, no hang and the pdf is saved as expected when File > Print > PDF > Save as PDF... > Save

I get the same results when actually printing these to hard copy.

Comment 13

[Jim Mathies [:jimm]]

(In reply to Jonathan Watt [:jwatt] from comment #5)
> The hang only seems to happen specifically when going through File > Print >
> PDF > Open PDF in Preview. The assertions still happen when opening the
> print dialog and when saving as a PDF file though.

I'm not able to reproduce this either using the latest nightly and this step.

Comment 14

[Jim Mathies [:jimm]]

jwatt, do you have any odd 3rd party pdf viewers installed? Also could you post your about:support?

It looks like your hanging while trying to launch a 3rd part viewer. We've tested with the default osx viewer and can't reproduce.

Comment 15

[Jonathan Watt [:jwatt]]

Attachment: jwatt's about:support

(In reply to Jim Mathies [:jimm] from comment #14)
> jwatt, do you have any odd 3rd party pdf viewers installed?

Nope. I have Apple's Preview Version 8.1 (877.7), the one that comes with OS X. I'm running OS X 10.11.4 (15E65).

Comment 16

[Jonathan Watt [:jwatt]]

The hang is occuring in a debug build of mozilla-central that I'm building myself. If I use the same profile with the latest nightly from ftp.mozilla.org I do not get the hang. Maybe it's something in my .mozconfig or toolchain that results in a build that's a bit different, or maybe it's an issue with debug builds. I'll explore further.

FWIW my .mozconfig contains:

export CC=clang
export CXX=clang++
. $topsrcdir/browser/config/mozconfig
ac_add_options --enable-dmd
ac_add_options --enable-dump-painting
ac_add_options --enable-debug --disable-optimize
ac_add_options --enable-debug-symbols
ac_add_options --disable-crashreporter

Comment 17

[Jonathan Watt [:jwatt]]

Still hangs with an optimized build, created by replacing the lines:

ac_add_options --enable-dmd
ac_add_options --enable-dump-painting
ac_add_options --enable-debug --disable-optimize

with:

ac_add_options --enable-optimize

Comment 18

[Jim Mathies [:jimm]]

Not blocking this based on the dependency of a local build. If we get any reports in release builds we can renom.