1278299 - Implement RTCSctpTransport and RTCPeerConnection.sctp

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, enhancement, P2)

Description

[Eric Shepherd [:sheppy]]

We need to add the sctp property to RTCPeerConnection and implement RTCSctpTransport, per:

http://w3c.github.io/webrtc-pc/#rtcpeerconnection-interface-extensions
http://w3c.github.io/webrtc-pc/#rtcsctptransport-interface

Comment 1

[Eric Shepherd [:sheppy]]

For what it's worth, I've written the overview page for this interface as currently specced:

https://developer.mozilla.org/en-US/docs/Web/API/RTCSctpTransport

The rest of the work will wait until it's implemented.

Comment 2

[Nils Ohlmeier [:drno]]

Looks to me like we first need to implement the RTCDtlsTransport before implementing RTPSctpTransport. Do we have a ticket for RTCDtlsTransport already (I only found bug 1258411, which refers "only" to documenting it)?

Comment 3

[Eric Shepherd [:sheppy]]

Probably not then. I filed my bugs for tracking docs work on these interfaces not realizing they weren't implemented yet. You'll probably want a bug for that. I can file it if you wish, or you guys can do it (which may make more sense, but up to you).

Comment 4

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 5

[Lennart Grahl [:lgrahl]]

FYI, this is the PR for the shim in adapter: https://github.com/webrtc/adapter/pull/702

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Now https://github.com/webrtcHacks/adapter/pull/702 I believe.

Comment 7

[Byron Campen [:bwc]]

Marking P2 since we're the last holdout.

Comment 8

[Byron Campen [:bwc]]

There's a little bit of work in flight in bug 1531087 that this would interact with, so marking as dependent.

Comment 9

[Byron Campen [:bwc]]

This should be relatively easy, I think, and doesn't depend on other stuff much.

Comment 10

[Byron Campen [:bwc]]

Huh. Spec says we update this when offer/answer completes, unlike RTCDtlsTransport when any local description or answer is set. That's... odd.

Comment 11

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=dccb873545707cff458336fe9245d55370dfbb2e
https://treeherder.mozilla.org/jobs?repo=try&revision=41ace02d9f347ec267a5ce61c4a306e985bee64f

Comment 12

[Byron Campen [:bwc]]

Attachment: Bug 1278299: Test cases for bug. r?ng

Removed a bad test-case from RTCDataChannel-send.html that was trying to
create gigabyte-sized buffers to test the max message size for DataChannel.

Depends on D168484

Comment 13

[Byron Campen [:bwc]]

Attachment: Bug 1278299: Implement RTCSctpTransport. r?ng

Depends on D169235

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d454deae329b
Test cases for bug. r=ng
https://hg.mozilla.org/integration/autoland/rev/7b6a4b55d6f7
Implement RTCSctpTransport. r=ng,webidl,saschanaz

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38509 for changes under testing/web-platform/tests

Comment 16

[Cristian Tuns]

Backed out for causing build bustages on PeerConnectionImpl.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp:2024:38: error: unused variable 'id' [-Werror=unused-variable]

mochitest log: https://treeherder.mozilla.org/logviewer?job_id=405685822&repo=autoland

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdc633959cb2
Test cases for bug. r=ng,smaug
https://hg.mozilla.org/integration/autoland/rev/8e74483e6bff
Implement RTCSctpTransport. r=ng,webidl,saschanaz

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38531 for changes under testing/web-platform/tests

Comment 20

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures in

Backout link: https://hg.mozilla.org/integration/autoland/rev/19e0bc283894a3bf801c7edb6c73879c3aeec836

Push with failures

Failure log #1 | TEST-UNEXPECTED-TIMEOUT | /webrtc/RTCPeerConnection-remote-track-mute.https.html | pc.close() on one side causes mute events on the other - Test timed out

Failure log #2 | TEST-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() audio and video validate all mandatory stats - assert_equals: Expect dictionary.transportId to be string expected "string" but got "undefined"

Failure log #3 | TEST-UNEXPECTED-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() on track associated with RTCRtpReceiver should return stats report containing inbound-rtp stats - assert_unreached: required stats <...>

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45b79c9f561d
Test cases for bug. r=ng,smaug
https://hg.mozilla.org/integration/autoland/rev/cb59dcbe34f2
Implement RTCSctpTransport. r=ng,webidl,saschanaz

Comment 23

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38985 for changes under testing/web-platform/tests

Comment 24

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/45b79c9f561d
https://hg.mozilla.org/mozilla-central/rev/cb59dcbe34f2

Comment 25

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 26

[Hamish Willee]

FYI MDN docs for this done in https://github.com/mdn/content/issues/26146, and are now complete (though waiting on browser compat data changes to be reviewed).