1531087 - RTCPeerConnectionStats ("peer-connection" RTCStatsType) support

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Comment 1

[Chris Mills [:cmills]]

We ought to think about whether we need to document all the stats types somewhere.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

We ought to think about whether we need to document all the stats types somewhere.

I'd recommend starting with the mandatory to implement subset.

Comment 3

[gudvinr]

web.skype.com need this:
TypeError: RTCPeerConnection.getStats: Argument 1 does not implement interface MediaStreamTrack.

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=1a3f4d25959a9c5f6532325f5ec7b128a82e7bda
https://treeherder.mozilla.org/jobs?repo=try&revision=0e663090e1f1bb6a10ab35e1dec3234a959f1a7d

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1531087: Implement RTCPeerConnectionStats. r?ng

Depends on D168433

Comment 6

[Byron Campen [:bwc]]

Goofed on one of the ini files, here's another wpt push.

https://treeherder.mozilla.org/jobs?repo=try&revision=5e6935b230a145502d4bd63ac008be2cb9751df5

Comment 7

[Byron Campen [:bwc]]

Try looks fine.

Comment 8

[Byron Campen [:bwc]]

Currently relies on the patches from bug 1813147; could possibly rebase, but as long as we can get bug 1813147 done, no need to do that.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bf440baea51
Implement RTCPeerConnectionStats. r=ng,webidl,smaug

Comment 10

[Cristian Tuns]

Backed out for causing build bustages on PeerConnectionImpl.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp:2024:38: error: unused variable 'id' [-Werror=unused-variable]

mochitest log: https://treeherder.mozilla.org/logviewer?job_id=405685822&repo=autoland

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bcc93903fe1
Implement RTCPeerConnectionStats. r=ng,webidl,smaug

Comment 12

[Sandor Molnar]

Backed out for causing wpt failures in

Backout link: https://hg.mozilla.org/integration/autoland/rev/19e0bc283894a3bf801c7edb6c73879c3aeec836

Push with failures

Failure log #1 | TEST-UNEXPECTED-TIMEOUT | /webrtc/RTCPeerConnection-remote-track-mute.https.html | pc.close() on one side causes mute events on the other - Test timed out

Failure log #2 | TEST-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() audio and video validate all mandatory stats - assert_equals: Expect dictionary.transportId to be string expected "string" but got "undefined"

Failure log #3 | TEST-UNEXPECTED-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() on track associated with RTCRtpReceiver should return stats report containing inbound-rtp stats - assert_unreached: required stats <...>

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af84cffee628
Implement RTCPeerConnectionStats. r=ng,webidl,smaug

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/af84cffee628

Comment 15

[Hamish Willee]

FYI MDN docs for this can be tracked inhttps://github.com/mdn/content/issues/26146

The docs and compatibility work is done, but not yet reviewed.