Status

defect
RESOLVED FIXED
3 years ago
11 months ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

(Depends on 1 bug)

unspecified
mozilla50
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

There's a discussion here with the intent to remove: https://lists.mozilla.org/pipermail/dev-platform/2016-June/015317.html.

Folder: toolkit/components/console/
Pref: devtools.errorconsole.enabled
See Also: → 1243550
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Going to give Bug 1243550 a bit of time before landing this.  Here's a tentative try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a48f77e47e8
Comment on attachment 8760948 [details]
Bug 1278368 - Remove the error console;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58344/diff/1-2/
Comment on attachment 8760948 [details]
Bug 1278368 - Remove the error console;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58344/diff/2-3/
Attachment #8760948 - Attachment description: Bug 1278368 - Remove the error console;r= → Bug 1278368 - Remove the error console;
Attachment #8760948 - Flags: review?(dolske)
https://reviewboard.mozilla.org/r/58344/#review57122

::: browser/base/content/test/general/browser.ini
(Diff revision 3)
>  [browser_bug559991.js]
>  [browser_bug561636.js]
>  skip-if = true # bug 1057615
>  [browser_bug563588.js]
>  [browser_bug565575.js]
> -[browser_bug565667.js]

I tried to port this test to use a different URL instead of console.xul but couldn't get it working locally.  I'm not sure (a) if the thing it's testing was only relevant for the console and if not then (b) if there's another xul file we could load in the test to get a similar effect
Attachment #8760948 - Flags: review?(dolske) → review+
Comment on attachment 8760948 [details]
Bug 1278368 - Remove the error console;

https://reviewboard.mozilla.org/r/58344/#review57326

ding-dong, it's dead.

One small comment on a test, not a requirement to fix.

::: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_nonbrowser.js:18
(Diff revision 3)
>    });
>  
>    let win = OpenBrowserWindow({private: true});
>    win.addEventListener("load", function onLoad() {
>      win.removeEventListener("load", onLoad, false);
> -    let consoleWin = win.open("chrome://global/content/console.xul", "_blank", "chrome,extrachrome,menubar,resizable,scrollbars,status,toolbar");
> +    let chromeWin = win.open("chrome://browser/content/preferences/permissions.xul", "_blank", "chrome,extrachrome,menubar,resizable,scrollbars,status,toolbar");

This is probably fine, but I twich a little about opening permissions.xul in an unexpected way.

win.open("about:blank") doesn't seem to open anything (disappointing!), but maybe places.xul would be better than permissions.xul? Realistic, too.
Comment on attachment 8760948 [details]
Bug 1278368 - Remove the error console;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58344/diff/3-4/
(In reply to Justin Dolske [:Dolske] from comment #6)

> win.open("about:blank") doesn't seem to open anything (disappointing!)

Oh, ha, actually this does work. I just noticed I have some tiny 16x32 windows on my desktop, which I didn't notice before. They're adorbs.
Lots of orange on the push but it doesn't look like it's any of the tests touched here
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/bb34ab2ea11b
Remove the error console. r=dolske
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bb34ab2ea11b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Product: Toolkit → Toolkit Graveyard
Depends on: 1302738
You need to log in before you can comment on or make changes to this bug.