1278470 - Typing in third party keyboard predictive typing ruins input

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Jamaicanboy63]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160502172042

Steps to reproduce:

So when i am typing using swiftkey in the search bar I can type in any thing for instance I type "Final" I see it in the predictive typing I tap the word I want it inputs "FFinal" it never use to do that for the past few updates.


Actual results:

Its adding an extra letter in that I confirm predictive typing 


Expected results:

It should just have that one word with no extra letter when I type and use the predictive word.

Comment 1

[Aaron Train [:aaronmt]]

This sounds like bug 1209052.

Comment 2

[Jamaicanboy63]

(In reply to Aaron Train [:aaronmt] from comment #1)
> This sounds like bug 1209052.

It's a different issue from that one. Predictive typing just adds an extra letter of the first word you type.

Comment 3

[Catalin Suciu [:csuciu]]

I can reproduce this issue in latest master using using GBoard, Swiftkey and Fleksy.

We should have this fixed before enabling by default the 3'rd party keyboard support.

Comment 4

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 5

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8888873 [details] [review]
Pull Request

LGTM, but as I stated in the PR, it might not hurt to have someone else also look over this code who is more familiar with it since it seems to make significant changes.

Comment 6

[Farhan Patel [:farhan]]

Agreed. I wish there was somebody who understood what was going on better. Our best bet is to give QA some time to do some testing with different keyboards.

Comment 7

[Farhan Patel [:farhan]]

https://github.com/mozilla-mobile/firefox-ios/commit/35383ea5439cf7e2f839cd8f1fb2bfa66e4194b9

Comment 8

[Catalin Suciu [:csuciu]]

Verified as fixed in master 35383ea54

Comment 9

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v8.x

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Reverted this patch in v8.x

Comment 11

[Farhan Patel [:farhan]]

This should be fixed by 
https://github.com/mozilla-mobile/firefox-ios/commit/b7d2697641fda38ee9851650f01fb62ad207adb5

The regressions created by the previous patch should also be fixed.

Comment 12

[Simon Basca [:SimonB]]

Verifying as fix on master 529fb6a46.

Comment 13

[Simon Basca [:SimonB]]

Verifying as fix on beta 8.2(5120).