127857 - Change scale textbox to dropdown (accomodating ``shrink to fit'') in print preview toolbar

Status: VERIFIED FIXED

(Core :: Print Preview, defect)

Description

[rods (gone)]

If the PrintSettings has "shtinktofit" set as true then the scaling UI needs to
be disabled.

Comment 1

[Peter Trudelle]

Nav triage team needs info: These seem to interoperate in a useful way, is there
a reason why it needs to be disabled?  How will users know why it is disabled?

cc marlon for UE input.

Comment 2

[marlon bishop]

Peter, that's true.  It should not be disabled, one should simply override the
other.  if we provided the actual value % in the box, as shrunk to fit, that
would be helpful in some cases.  so if user changes that value to something else
then  we uncheck the box. 

Comment 3

[Peter Trudelle]

Thanks Marlon!

nsbeta1- per Nav triage team, ->1.2.

Comment 4

[Samir Gehani]

OK, then let's morph this bug or close it in favor of a new one that gets the
current % based on shrink to fit.

Comment 5

[Samir Gehani]

This bug will deal with the originally reported defect although we will
implement the following solution:

(*) discrete values in a drop down instead of the scale textfield
(*) last value will be ``Shrink to fit'' (or ``Fit to page width''/doc's wording) 

(Morphing bugs is evil but this deals with the original issue we are trying to
tackle.)  Renominating for nsbeta1.

Comment 6

[Peter Trudelle]

nsbeta1+/adt2 per Nav triage team

Comment 7

[rods (gone)]

Attachment: patch

Add new methods to check the PrintSettings for its current values and setup the
UI appropriately. It is also called after a return from Print Preview.

Comment 8

[Samir Gehani]

The agreed design is documented in comment 5.  The patch in comment 7 doesn't
appear to match the agreed design.

Comment 9

[rods (gone)]

taking

Comment 10

[rods (gone)]

Attachment: patch with combobox

This uses a combobox for discrete values, Cutom and ShrinkToFit

Comment 11

[rods (gone)]

The combobox doesn't show up Linux (which is correct) until 119491 gets fixed.

Comment 12

[Samir Gehani]

Comment on attachment 82195 [details] [diff] [review]
patch with combobox

>+      <xul:data value="&customPrompt.title;"/>

I can see us using the xul:data strategy to get the string if we plan on
landing this in beta (since strings are frozen for now) but the trunk (and
post-beta branch?) should use the string bundle strategy.

>       <field name="mDebug">
>-        false
>+        true
>       </field>

I think you forgot to switch this back to false since I take it you are done
debugging.  :o)

>+          // XXXsamir the type was mismatched

We can lose this line.

With those changes r=sgehani.

Comment 13

[Alec Flett]

Comment on attachment 82195 [details] [diff] [review]
patch with combobox

sr=alecf, but man it sure would be nice if we didn't have to hardcode the
childNodes[] indexes.

Comment 14

[rods (gone)]

Attachment: final patch with suggested changes

made samir's changes

Comment 15

[rods (gone)]

Comment on attachment 82579 [details] [diff] [review]
final patch with suggested changes

Bringing r and sr forward

Comment 16

[rods (gone)]

Attachment: final patch merged with tree

Some of the changes for this patch are already in the tree, this is the reduced
patch.

Comment 17

[rods (gone)]

Comment on attachment 82636 [details] [diff] [review]
final patch merged with tree

bringing r/sr forward

Comment 18

[sujay]

Can we do something about this bug? we're gonna get a flodd of bugs
saying that scale does not work. users are not gonna figure out
easily that they have to go into Page Setup and disable STF.

Comment 19

[rods (gone)]

fixed on trunk

Comment 20

[sujay]

verified in 5/9 trunk build.

Comment 21

[scottputterman]

adding adt1.0.0+.  Please get drivers approval and then checkin to the 1.0 branch.

Comment 22

[chris hofmann]

Comment on attachment 82636 [details] [diff] [review]
final patch merged with tree

a=chofmann,dbaron,valeski for the 1.0 branch.

Comment 23

[rods (gone)]

Attachment: minor additional changes

These small set of changes are need because Bug 115136 has not yet been checked
into the branch. These changes are merely to pass back whether the PageSetup
Dialog was ok'ed or cancelled. These tested out fine on Windows and Linux, will
test on Mac.

Comment 24

[Marc Attinasi]

Comment on attachment 83887 [details] [diff] [review]
minor additional changes

sr=attinasi

Comment 25

[dcone (gone)]

Comment on attachment 83887 [details] [diff] [review]
minor additional changes

r=dcone

Comment 26

[rods (gone)]

fixed on branch

Comment 27

[sujay]

this bug is not fixed on 5/20 branch.

Comment 28

[rods (gone)]

cvs shows I checked it in:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/xpfe/communicator/resources/content&command=DIFF_FRAMESET&file=printPreviewBindings.xml&rev1=1.7.2.1&rev2=1.7.2.2&root=/cvsroot

Comment 29

[Kevin McCluskey (gone)]

WFM: Bug is fixed on WinNT and WinXP using 2002-5-20 branch build for me.

Comment 30

[sujay]

verified in 5/21 branch build.