Closed
Bug 1278759
Opened 8 years ago
Closed 8 years ago
Add tests to make sure accessibility tree is not affected by CSS flexbox markup
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
Details
Attachments
(1 file)
In bug 812687, the tab order for flex box will be fixed to match the DOM order again, regardless of CSS flexbox markup. Right now, the accessibility tree is not affected by flexbox ordering, so I want to add tree tests that make sure we test against this to catch regressions in the future if they arise.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/58432/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58432/
Attachment #8761078 -
Flags: review?(surkov.alexander)
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=91c3a8915c1e
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8761078 [details] Bug 1278759 - Add tests to make sure accessibility tree is not affected by CSS flexbox markup, Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58432/diff/1-2/
|
||
Comment 4•8 years ago
|
||
<div> style="display: flex;"> does not have an accessible?
|
|
Assignee | |
Comment 5•8 years ago
|
||
(In reply to alexander :surkov from comment #4) > <div> style="display: flex;"> does not have an accessible? No.
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8761078 [details] Bug 1278759 - Add tests to make sure accessibility tree is not affected by CSS flexbox markup, https://reviewboard.mozilla.org/r/58432/#review55344 r=me, thanks for adding it! ::: accessible/tests/mochitest/tree/test_cssflexbox.html:5 (Diff revision 2) > +<!DOCTYPE html> > +<html> > + > +<head> > + <title>HTML form controls tests</title> needs update ::: accessible/tests/mochitest/tree/test_cssflexbox.html:21 (Diff revision 2) > + > + <script type="application/javascript"> > + function doTest() > + { > + // Ensure that flexbox ordering and absolute positioning do not affect > + // the accessibility tree. would be good to comment that DIV display:flex doesn't have an accessible object ::: accessible/tests/mochitest/tree/test_cssflexbox.html:44 (Diff revision 2) > + name: "Third" > + }, // end bug 1277559 > + { // Bug 962558: DOM first, Order 2. > + role: ROLE_PUSHBUTTON, > + name: "two, tab first" > + }, nit: whitespace
Attachment #8761078 -
Flags: review?(surkov.alexander) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8761078 [details] Bug 1278759 - Add tests to make sure accessibility tree is not affected by CSS flexbox markup, Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58432/diff/2-3/
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → mzehe
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 8•8 years ago
|
||
Comment on attachment 8761078 [details] Bug 1278759 - Add tests to make sure accessibility tree is not affected by CSS flexbox markup, Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58432/diff/3-4/
Attachment #8761078 -
Attachment description: Bug1278759 - Add tests to make sure accessibility tree is not affected by CSS flexbox markup, → Bug 1278759 - Add tests to make sure accessibility tree is not affected by CSS flexbox markup,
Pushed by mzehe@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e5b9e25cd47e Add tests to make sure accessibility tree is not affected by CSS flexbox markup, r=surkov
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e5b9e25cd47e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•