Closed Bug 1279017 Opened 4 years ago Closed 4 years ago

Remove code specific to 10.6-10.8 in widget/cocoa

Categories

(Core :: Widget: Cocoa, defect)

Unspecified
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch Clean up widget/cocoa (obsolete) — Splinter Review
We still build on 10.7, but we don't support running anything < 10.9.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #8761351 - Flags: review?(mstange)
Comment on attachment 8761351 [details] [diff] [review]
Clean up widget/cocoa

Review of attachment 8761351 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsLookAndFeel.mm
@@ +510,5 @@
>  }
>  
>  bool nsLookAndFeel::AllowOverlayScrollbarsOverlap()
>  {
> +  return (UseOverlayScrollbars());

remove extraneous parens
Attachment #8761351 - Flags: review?(mstange) → review+
OS: Unspecified → Mac OS X
Pushed by stefanh@inbox.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9a46afd9375
Remove code specific to 10.6-10.8 in widget/cocoa. r=mstange.
Hmm, that's... odd.
Comment on attachment 8761351 [details] [diff] [review]
Clean up widget/cocoa

Review of attachment 8761351 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsNativeThemeCocoa.mm
@@ +2340,5 @@
>  
>  static bool
>  ScrollbarTrackAndThumbDrawSeparately()
>  {
> +  return nsLookAndFeel::UseOverlayScrollbars();

This change isn't correct
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #7)
> Comment on attachment 8761351 [details] [diff] [review]
> Clean up widget/cocoa
> 
> Review of attachment 8761351 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: widget/cocoa/nsNativeThemeCocoa.mm
> @@ +2340,5 @@
> >  
> >  static bool
> >  ScrollbarTrackAndThumbDrawSeparately()
> >  {
> > +  return nsLookAndFeel::UseOverlayScrollbars();
> 
> This change isn't correct

Oh, right - ScrollbarTrackAndThumbDrawSeparately() should always return true now (so we also have no use for it). Thanks!
I'm going to put up a new patch in a few days - I see now that more scrollbar-related code can be removed.
Attached patch New versionSplinter Review
Now with more scrollbar-related code removed.
Attachment #8761351 - Attachment is obsolete: true
Attachment #8762175 - Flags: review?(mstange)
Attachment #8762175 - Flags: review?(mstange) → review+
Pushed by stefanh@inbox.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/22f34da35017
Remove code specific to 10.6-10.8 in widget/cocoa. r=mstange.
https://hg.mozilla.org/mozilla-central/rev/22f34da35017
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Blocks: 1282251
Depends on: 1284464
You need to log in before you can comment on or make changes to this bug.