Closed
Bug 1279017
Opened 8 years ago
Closed 8 years ago
Remove code specific to 10.6-10.8 in widget/cocoa
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: stefanh, Assigned: stefanh)
References
Details
Attachments
(1 file, 1 obsolete file)
47.44 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
We still build on 10.7, but we don't support running anything < 10.9.
Assignee | ||
Comment 2•8 years ago
|
||
Try run (just pushed): https://treeherder.mozilla.org/#/jobs?repo=try&revision=7eb0b4ee382f
Comment 3•8 years ago
|
||
Comment on attachment 8761351 [details] [diff] [review]
Clean up widget/cocoa
Review of attachment 8761351 [details] [diff] [review]:
-----------------------------------------------------------------
::: widget/cocoa/nsLookAndFeel.mm
@@ +510,5 @@
> }
>
> bool nsLookAndFeel::AllowOverlayScrollbarsOverlap()
> {
> + return (UseOverlayScrollbars());
remove extraneous parens
Attachment #8761351 -
Flags: review?(mstange) → review+
Assignee | ||
Updated•8 years ago
|
OS: Unspecified → Mac OS X
Pushed by stefanh@inbox.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9a46afd9375
Remove code specific to 10.6-10.8 in widget/cocoa. r=mstange.
Comment 5•8 years ago
|
||
Apparently something in there was making async scrolling reftests on e10s work on 10.10, https://treeherder.mozilla.org/logviewer.html#?job_id=29835206&repo=mozilla-inbound
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/79fdba402322d545a40702e2894c9960685da06e
Assignee | ||
Comment 6•8 years ago
|
||
Hmm, that's... odd.
Comment 7•8 years ago
|
||
Comment on attachment 8761351 [details] [diff] [review]
Clean up widget/cocoa
Review of attachment 8761351 [details] [diff] [review]:
-----------------------------------------------------------------
::: widget/cocoa/nsNativeThemeCocoa.mm
@@ +2340,5 @@
>
> static bool
> ScrollbarTrackAndThumbDrawSeparately()
> {
> + return nsLookAndFeel::UseOverlayScrollbars();
This change isn't correct
Assignee | ||
Comment 8•8 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #7)
> Comment on attachment 8761351 [details] [diff] [review]
> Clean up widget/cocoa
>
> Review of attachment 8761351 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: widget/cocoa/nsNativeThemeCocoa.mm
> @@ +2340,5 @@
> >
> > static bool
> > ScrollbarTrackAndThumbDrawSeparately()
> > {
> > + return nsLookAndFeel::UseOverlayScrollbars();
>
> This change isn't correct
Oh, right - ScrollbarTrackAndThumbDrawSeparately() should always return true now (so we also have no use for it). Thanks!
Assignee | ||
Comment 9•8 years ago
|
||
I'm going to put up a new patch in a few days - I see now that more scrollbar-related code can be removed.
Assignee | ||
Comment 10•8 years ago
|
||
Now with more scrollbar-related code removed.
Attachment #8761351 -
Attachment is obsolete: true
Attachment #8762175 -
Flags: review?(mstange)
Assignee | ||
Comment 11•8 years ago
|
||
Updated•8 years ago
|
Attachment #8762175 -
Flags: review?(mstange) → review+
Comment 12•8 years ago
|
||
Pushed by stefanh@inbox.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/22f34da35017
Remove code specific to 10.6-10.8 in widget/cocoa. r=mstange.
Comment 13•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•