1279048 - Use MOZ_SOURCE_REPO for source file mapping in buildsymbols

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mats Palmgren (inactive)]

13:45:33     INFO -  Failed to get HG Repo for c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src
13:45:33     INFO -  Could not determine repo info for c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src.  This is either not a clone of the web-based
13:45:33     INFO -  repository, or you have not specified SRCSRV_ROOT, or the clone is corrupt.
13:45:33     INFO -  Failed to get HG Repo for c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src
13:45:33     INFO -  Could not determine repo info for c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src.  This is either not a clone of the web-based
13:45:33     INFO -  repository, or you have not specified SRCSRV_ROOT, or the clone is corrupt.

[...]

mozmake.EXE[4]: *** [buildsymbols] Error 1
mozmake.EXE[3]: *** [automation/buildsymbols] Error 2
mozmake.EXE[3]: *** Waiting for unfinished jobs....
mozmake.EXE[2]: *** [automation/build] Error 2
mozmake.EXE[1]: *** [realbuild] Error 2
mozmake.EXE: *** [build] Error 2
Return code: 1 


https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e803302f3c7&selectedJob=22199087

Comment 1

[Gregory Szorc [:gps]]

This is a regression from the work in bug 1270317. We no longer have a straight clone of individual repos in automation so we can't trust that .hg/hgrc has the appropriate [path] entries. The repo URL will need to be obtained from environment variables, similar to what's done in build/variables.py - see bug 1274655.

Come to think of it, the bug here is likely that symbolstore.py isn't using the VCS info set by variables.py (it has its own code for reading hg repo info).

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1279048 - Check MOZ_SOURCE_REPO for repository URL;

MOZ_SOURCE_REPO is set by automation to indicate the URL of the current
repository. I'm not sure what SRCSRV_ROOT is from. Probably legacy.

Use MOZ_SOURCE_REPO instead of SRCSRV_ROOT.

Review commit: https://reviewboard.mozilla.org/r/58612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58612/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8761396 [details]
Bug 1279048 - Check MOZ_SOURCE_REPO for repository URL;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58612/diff/1-2/

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 8761396 [details]
Bug 1279048 - Check MOZ_SOURCE_REPO for repository URL;

https://reviewboard.mozilla.org/r/58612/#review57902

`SRCSRV_ROOT` dates back to the days of CVS(!) when we needed to manually specify the repository path. Replacing it here should be fine.

::: toolkit/crashreporter/tools/symbolstore.py:139
(Diff revision 2)
>      return stdout.rstrip()
>  
>  class HGRepoInfo:
>      def __init__(self, path):
>          self.path = path
>          rev = read_output('hg', '-R', path,

It'd be nice to also honor `MOZ_SOURCE_CHANGESET`.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8761396 [details]
Bug 1279048 - Check MOZ_SOURCE_REPO for repository URL;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58612/diff/2-3/

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 8761396 [details]
Bug 1279048 - Check MOZ_SOURCE_REPO for repository URL;

https://reviewboard.mozilla.org/r/58612/#review60030

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/229cd3b8bf5d
Check MOZ_SOURCE_REPO for repository URL; r=ted

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for build bustage: https://hg.mozilla.org/integration/autoland/rev/53b24e115c19

https://treeherder.mozilla.org/logviewer.html#?job_id=403174&repo=autoland

Comment 11

[Gregory Szorc [:gps]]

Working on this now.

Comment 12

[Gregory Szorc [:gps]]

Comment on attachment 8761396 [details]
Bug 1279048 - Check MOZ_SOURCE_REPO for repository URL;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58612/diff/3-4/

Comment 13

[(not currently active) Ted Mielczarek]

Comment on attachment 8761396 [details]
Bug 1279048 - Check MOZ_SOURCE_REPO for repository URL;

https://reviewboard.mozilla.org/r/58612/#review75672

Thanks for getting back to this!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/19395c1734f2
Check MOZ_SOURCE_REPO for repository URL; r=ted

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/19395c1734f2

Comment 16

[Gregory Szorc [:gps]]

Comment on attachment 8761396 [details]
Bug 1279048 - Check MOZ_SOURCE_REPO for repository URL;

Approval Request Comment
[Feature/regressing bug #]: bug 1270317
[User impact if declined]: debug symbols may not be attributed to proper repository, confuses crash reporting
[Describe test coverage new/current, TreeHerder]: there is a unit test. ted will provide confirmation that symbols produced with this change behave properly
[Risks and why]: automation only change. should be low. it either works or it doesn't
[String/UUID change made/needed]: none

Ted: could you please spot check and sign off that this patch fixed things?

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8761396 [details]
Bug 1279048 - Check MOZ_SOURCE_REPO for repository URL;

[Triage Comment]

OK to uplift, should only affect debug symbols.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/08c1069d87f6

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/af42e0b7e0e5

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/af42e0b7e0e5

Comment 21

[(not currently active) Ted Mielczarek]

I spot checked a few symbol files from nightly builds and they all look OK.