1279428 - (Potentially) Deprecate channel->AsyncOpen()

Status: RESOLVED DUPLICATE of bug 1411609

(Core :: DOM: Security, defect, P4)

Description

[Christoph Kerschbaumer [:ckerschb]]

I am not sure if we will be able to deprecate asyncOpen() that easily, because lots of addons still rely on it. Since we are getting closer with converting all callsites within Gecko to use AsyncOpen2() however, we should discuss options.

There are several options:
[please note that the following list is not complete]
* Keep AsyncOpen() and AsyncOpen2() in parallel (basically what we have right now) and just have AsyncOpen2() forward it's calls to asyncOpen().
* Remove AsyncOpen() and move logic from AsyncOpen() into AsyncOpen2().
* ...

Whatever we decide, this change will affect addons and if we decide to deprecate asyncOpen() then we should start adding deprecation warnings.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1279428_deprecate_channel_asyncopen.patch

Here is a current WIP patch which we can use to make sure all gecko internals rely on asyncOpen2() rather than calling asyncOpen().

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Pat, would it make sense for FF58 to remove asyncOpen(). Potentially even remove the functionality of asyncOpen() and have asyncOpen2() be renamed to asyncOpen()?

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

Clearing the ni? for Pat since we are going to track progress over in Bug 1411609.