1279454 - Fix position of vertical scrollbar in devtools DOM

Status: VERIFIED FIXED

(DevTools :: DOM, defect, P1)

Description

[magicp]

Attachment: devtools-dom-vertical-scrollbar.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160609130607

Steps to reproduce:

1. Start Nightly
2. Open devtools > DOM


Actual results:

Vertical scrollbar overlaps on toolbar. The searchbox will be moved (not fixed in place) if no result.


Expected results:

Vertical scrollbar should not overlap on toolbar.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1279454.patch

Fixing vertical scrollbar position.

Honza

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8798845 [details] [diff] [review]
bug1279454.patch

Review of attachment 8798845 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine for me locally!

::: devtools/client/dom/content/dom-view.css
@@ +18,5 @@
> +  height: 100vh;
> +}
> +
> +.mainFrame > .treeTableBox {
> +  flex: 1 1 auto;

nit: Use flex-grow: 1;

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/ea311deedce9
Fix position of vertical scrollbar in devtools DOM; r=ntim

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ea311deedce9

Comment 6

[Sebastian Zartner [:sebo]]

Fixed for me in Nightly 2016-10-10. Thank you, Honza!

Sebastian