1279708 - highlight is wrong if scrolled

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Alice0775 White]

Attachment: bug.html

Steps to reproduce:
1. open attached
2. Ctrl+f, type bla
3. Hit ENTER and repeat Step.3

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]:

I can still reproduce on Nightly51.0a1

https://hg.mozilla.org/mozilla-central/rev/7e873393cc11d326338779e5a3ed2da031e30936
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 ID:20160911030419

Comment 3

[Marco Castelluccio [:marco]]

This is probably a duplicate of bug 1279695.

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to Marco Castelluccio [:marco] from comment #3)
> This is probably a duplicate of bug 1279695.

No this is a different bug, in that we don't recalculate the geometry of ranges when we scrollIntoView the current found range.

Comment 5

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1279708 - update the geometry of all ranges upon the next dimmed mask repaint in the case of a 'findAgain' update, because the page may have scrolled.

Review commit: https://reviewboard.mozilla.org/r/78998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78998/

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8791624 [details]
Bug 1279708 - update the geometry of all ranges upon the next dimmed mask repaint in the case of a 'findAgain' update, because the page may have scrolled.

https://reviewboard.mozilla.org/r/78998/#review77616

Should this have a test for it?

Comment 7

[Mike de Boer [:mikedeboer]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
> Should this have a test for it?

I'll work on a test asap, in another bug.

Comment 8

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/integration/fx-team/rev/4b1afa9d2e99ff11f590c253e33f65ec49157ea8
Bug 1279708 - update the geometry of all ranges upon the next dimmed mask repaint in the case of a 'findAgain' update, because the page may have scrolled. r=jaws

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/945d91bffbdd
update the geometry of all ranges upon the next dimmed mask repaint in the case of a 'findAgain' update, because the page may have scrolled. r=jaws

Comment 10

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/integration/fx-team/rev/6ac553163f6b9f2f5565fe09b8afdffa0d820984
Backed out changeset 4b1afa9d2e99 (bug 1279708), because it landed on autoland earlier. r=backout DONTBUILD

Comment 11

[Marcia Knous [:marcia]]

Tracking 51+.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/945d91bffbdd

Comment 13

[Simona Badau, Desktop QA]

I've reproduced the initial issue on Nightly 50.0a1 (Build ID: 20160611030214) on Windows 10. 

Verified fixed (when following the STR from the description) using Nightly 52 (Build ID: 20160919065232) on Windows 10, Ubuntu 16.04 and Mac OS X 10.11. 

But, the issue is still reproducible if scrolling is done via mouse. Please see the attached screen-cast.

Mike, will the above issue be covered by Bug 1279695? Please let me know if I should log a new bug to cover the scrolling via mouse issue.

Comment 14

[Simona Badau, Desktop QA]

Attachment: scroolling via mouse.mp4

Comment 15

[Mike de Boer [:mikedeboer]]

(In reply to Simona B [:simonab ] from comment #13)
> Mike, will the above issue be covered by Bug 1279695? Please let me know if
> I should log a new bug to cover the scrolling via mouse issue.

This is covered by bug 1302534.

Comment 16

[Simona Badau, Desktop QA]

Based on Comment 15, setting the status of this issue to Verified Fixed. 

I'm also removing the qa-verify flag since this Feature is disabled by default on Firefox 51.

Comment 17

[Brindusa Tot, DTE]

Based on previous comment

> I'm also removing the qa-verify flag since this Feature is disabled by
> default on Firefox 51.

update status-firefox51 to Disabled.