1280017 - Intermittent Could not install python package: /builds/slave/test/build/venv/bin/pip install --timeout 120 -r /builds/slave/test/build/tests/config/external-media-tests-requirements.txt --no-index --find-links http://pypi.pvt.build.mozilla.org.proxxy1.srv

Status: RESOLVED FIXED

(Testing Graveyard :: external-media-tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://treeherder.mozilla.org/logviewer.html#?job_id=30098696&repo=mozilla-inbound#L1344

We fail to install the new puppeteer package due to the version bump on bug 1265028.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

Review commit: https://reviewboard.mozilla.org/r/59208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59208/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59208/diff/1-2/

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

https://reviewboard.mozilla.org/r/59208/#review56240

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The patch will make two changes:

1. It corrects the order of requirements. As of now the external media tests requirement file gets processed first which means it would download puppeteer. Instead it should first make use of the in-tree version

2. A bit more sloppy version requirement so we don't have to update the dependency each time we release a new puppeteer release for a version of Firefox. 

I triggered a try build. If that passes I will ask for review (even Maja already reviewed the patch).

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59208/diff/2-3/

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59208/diff/3-4/

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Strangely the try build didn't pick up the changes I have made on that bug. Given that it is just a version change I feel confident in pushing it to inbound.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9df1a5b09946
Fix firefox-puppeteer requirement for external media tests. r=maja_zf

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Still seeing the issue, e.g. on the push which should have fixed it: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=9df1a5b099468265f18a710727cc557272024408

b-y: https://treeherder.mozilla.org/logviewer.html#?job_id=30129499&repo=mozilla-inbound
b-m: https://treeherder.mozilla.org/logviewer.html#?job_id=30124565&repo=mozilla-inbound

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Maybe the problem here happens because of an old pip release. I tested the patch locally where all was working fine. So I changed the way how we specify dependencies, and pushed to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1cc4f0111c4

Lets see how that works.

Comment 11

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

https://reviewboard.mozilla.org/r/59208/#review56270

Comment 12

[Intermittent Failures Robot]

124 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 124

Platform breakdown:
* linux64: 55
* windows7-32: 34
* windows8-64: 21
* osx-10-10: 14

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280017&startday=2016-06-14&endday=2016-06-14&tree=all

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9df1a5b09946

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Final bustage fix

It was indeed a problem with an older pip version by specifying the version range with ~=. So my try push with >=, < was successful:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1cc4f0111c4

I will get this landed immediately to stop the bustage.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Final patch got landed as https://hg.mozilla.org/integration/mozilla-inbound/rev/f40b29f8d684

Comment 16

[Intermittent Failures Robot]

87 automation job failures were associated with this bug yesterday.

Repository breakdown:
* fx-team: 48
* mozilla-inbound: 30
* mozilla-central: 9

Platform breakdown:
* windows7-32: 36
* windows8-64: 19
* linux64: 16
* osx-10-10: 15
* windowsxp: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280017&startday=2016-06-15&endday=2016-06-15&tree=all

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f40b29f8d684

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We need this code on mozilla-aurora. But before landing the two commits please land the commit from bug 1265028 first. Thanks.

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c12e8f7a5605
https://hg.mozilla.org/releases/mozilla-aurora/rev/654fc37e64d5

Comment 20

[Intermittent Failures Robot]

224 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 167
* fx-team: 48
* mozilla-central: 9

Platform breakdown:
* linux64: 79
* windows7-32: 71
* windows8-64: 43
* osx-10-10: 30
* windowsxp: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280017&startday=2016-06-13&endday=2016-06-19&tree=all