Closed Bug 1280017 Opened 4 years ago Closed 4 years ago

Intermittent Could not install python package: /builds/slave/test/build/venv/bin/pip install --timeout 120 -r /builds/slave/test/build/tests/config/external-media-tests-requirements.txt --no-index --find-links http://pypi.pvt.build.mozilla.org.proxxy1.srv

Categories

(Testing Graveyard :: external-media-tests, defect)

50 Branch
defect
Not set
normal

Tracking

(firefox49 fixed, firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Keywords: regression)

Attachments

(2 files)

https://treeherder.mozilla.org/logviewer.html#?job_id=30098696&repo=mozilla-inbound#L1344

We fail to install the new puppeteer package due to the version bump on bug 1265028.
Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59208/diff/1-2/
The patch will make two changes:

1. It corrects the order of requirements. As of now the external media tests requirement file gets processed first which means it would download puppeteer. Instead it should first make use of the in-tree version

2. A bit more sloppy version requirement so we don't have to update the dependency each time we release a new puppeteer release for a version of Firefox. 

I triggered a try build. If that passes I will ask for review (even Maja already reviewed the patch).
Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59208/diff/2-3/
Attachment #8762662 - Attachment description: Bug 1280017 - Fix firefox-puppeteer requirement for external media tests → Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.
Attachment #8762662 - Flags: review+ → review?(bvandyk)
Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59208/diff/3-4/
Attachment #8762662 - Flags: review?(bvandyk)
Strangely the try build didn't pick up the changes I have made on that bug. Given that it is just a version change I feel confident in pushing it to inbound.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9df1a5b09946
Fix firefox-puppeteer requirement for external media tests. r=maja_zf
Maybe the problem here happens because of an old pip release. I tested the patch locally where all was working fine. So I changed the way how we specify dependencies, and pushed to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1cc4f0111c4

Lets see how that works.
Flags: needinfo?(hskupin)
https://hg.mozilla.org/mozilla-central/rev/9df1a5b09946
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
It was indeed a problem with an older pip version by specifying the version range with ~=. So my try push with >=, < was successful:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1cc4f0111c4

I will get this landed immediately to stop the bustage.
Attachment #8762793 - Flags: review+
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/f40b29f8d684
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
We need this code on mozilla-aurora. But before landing the two commits please land the commit from bug 1265028 first. Thanks.
Whiteboard: [checkin-needed-aurora]
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.