Intermittent Could not install python package: /builds/slave/test/build/venv/bin/pip install --timeout 120 -r /builds/slave/test/build/tests/config/external-media-tests-requirements.txt --no-index --find-links http://pypi.pvt.build.mozilla.org.proxxy1.srv

RESOLVED FIXED in Firefox 49

Status

Testing
external-media-tests
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

({regression})

50 Branch
mozilla50
regression
Points:
---

Firefox Tracking Flags

(firefox49 fixed, firefox50 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

a year ago
https://treeherder.mozilla.org/logviewer.html#?job_id=30098696&repo=mozilla-inbound#L1344

We fail to install the new puppeteer package due to the version bump on bug 1265028.
(Assignee)

Comment 1

a year ago
Created attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

Review commit: https://reviewboard.mozilla.org/r/59208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59208/
(Assignee)

Comment 2

a year ago
Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59208/diff/1-2/
Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

https://reviewboard.mozilla.org/r/59208/#review56240
Attachment #8762662 - Flags: review+
(Assignee)

Comment 4

a year ago
The patch will make two changes:

1. It corrects the order of requirements. As of now the external media tests requirement file gets processed first which means it would download puppeteer. Instead it should first make use of the in-tree version

2. A bit more sloppy version requirement so we don't have to update the dependency each time we release a new puppeteer release for a version of Firefox. 

I triggered a try build. If that passes I will ask for review (even Maja already reviewed the patch).
(Assignee)

Comment 5

a year ago
Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59208/diff/2-3/
Attachment #8762662 - Attachment description: Bug 1280017 - Fix firefox-puppeteer requirement for external media tests → Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.
Attachment #8762662 - Flags: review+ → review?(bvandyk)
(Assignee)

Comment 6

a year ago
Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59208/diff/3-4/
Attachment #8762662 - Flags: review?(bvandyk)
(Assignee)

Comment 7

a year ago
Strangely the try build didn't pick up the changes I have made on that bug. Given that it is just a version change I feel confident in pushing it to inbound.

Comment 8

a year ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9df1a5b09946
Fix firefox-puppeteer requirement for external media tests. r=maja_zf
Still seeing the issue, e.g. on the push which should have fixed it: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=9df1a5b099468265f18a710727cc557272024408

b-y: https://treeherder.mozilla.org/logviewer.html#?job_id=30129499&repo=mozilla-inbound
b-m: https://treeherder.mozilla.org/logviewer.html#?job_id=30124565&repo=mozilla-inbound
Flags: needinfo?(hskupin)
(Assignee)

Comment 10

a year ago
Maybe the problem here happens because of an old pip release. I tested the patch locally where all was working fine. So I changed the way how we specify dependencies, and pushed to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1cc4f0111c4

Lets see how that works.
Flags: needinfo?(hskupin)
Comment on attachment 8762662 [details]
Bug 1280017 - Fix firefox-puppeteer requirement for external media tests.

https://reviewboard.mozilla.org/r/59208/#review56270
Attachment #8762662 - Flags: review+
124 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 124

Platform breakdown:
* linux64: 55
* windows7-32: 34
* windows8-64: 21
* osx-10-10: 14

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280017&startday=2016-06-14&endday=2016-06-14&tree=all

Comment 13

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9df1a5b09946
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
(Assignee)

Comment 14

a year ago
Created attachment 8762793 [details] [diff] [review]
Final bustage fix

It was indeed a problem with an older pip version by specifying the version range with ~=. So my try push with >=, < was successful:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1cc4f0111c4

I will get this landed immediately to stop the bustage.
Attachment #8762793 - Flags: review+
(Assignee)

Comment 15

a year ago
Final patch got landed as https://hg.mozilla.org/integration/mozilla-inbound/rev/f40b29f8d684
status-firefox49: --- → affected
(Assignee)

Updated

a year ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
87 automation job failures were associated with this bug yesterday.

Repository breakdown:
* fx-team: 48
* mozilla-inbound: 30
* mozilla-central: 9

Platform breakdown:
* windows7-32: 36
* windows8-64: 19
* linux64: 16
* osx-10-10: 15
* windowsxp: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280017&startday=2016-06-15&endday=2016-06-15&tree=all

Comment 17

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f40b29f8d684
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
Resolution: --- → FIXED
(Assignee)

Comment 18

a year ago
We need this code on mozilla-aurora. But before landing the two commits please land the commit from bug 1265028 first. Thanks.
Whiteboard: [checkin-needed-aurora]

Comment 19

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/c12e8f7a5605
https://hg.mozilla.org/releases/mozilla-aurora/rev/654fc37e64d5
status-firefox49: affected → fixed
Whiteboard: [checkin-needed-aurora]
224 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 167
* fx-team: 48
* mozilla-central: 9

Platform breakdown:
* linux64: 79
* windows7-32: 71
* windows8-64: 43
* osx-10-10: 30
* windowsxp: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280017&startday=2016-06-13&endday=2016-06-19&tree=all
You need to log in before you can comment on or make changes to this bug.