1280445 - MediaStreamGraph holding on to Images until after gfx shutdown

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P1)

Description

[Andreas Pehrson [:pehrsons]]

This will be the short term fix of clearing out all Images during CC Unlink.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1280445 - Remove wrapper from MediaStream.

Review commit: https://reviewboard.mozilla.org/r/59424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59424/

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1280445 - Clear out all MediaSegments directly on forced MediaStreamGraph shutdown.

Review commit: https://reviewboard.mozilla.org/r/59426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59426/

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1280445 - Don't hold on to Image in MediaEngineDefaultVideoSource after Stop().

Review commit: https://reviewboard.mozilla.org/r/59428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59428/

Comment 4

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8763092 [details]
Bug 1280445 - Don't hold on to Image in MediaEngineDefaultVideoSource after Stop().

https://reviewboard.mozilla.org/r/59428/#review56492

Comment 5

[Andreas Pehrson [:pehrsons]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5402d190da86

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8763091 [details]
Bug 1280445 - Clear out all MediaSegments directly on forced MediaStreamGraph shutdown.

https://reviewboard.mozilla.org/r/59426/#review56500

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8763090 [details]
Bug 1280445 - Remove wrapper from MediaStream.

https://reviewboard.mozilla.org/r/59424/#review56502

Comment 8

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1280445 - Clean up MediaStreamAudioSourceNode's TrackListener on destruction.

Review commit: https://reviewboard.mozilla.org/r/61264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61264/

Comment 9

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8763090 [details]
Bug 1280445 - Remove wrapper from MediaStream.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59424/diff/1-2/

Comment 10

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8763091 [details]
Bug 1280445 - Clear out all MediaSegments directly on forced MediaStreamGraph shutdown.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59426/diff/1-2/

Comment 11

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8763092 [details]
Bug 1280445 - Don't hold on to Image in MediaEngineDefaultVideoSource after Stop().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59428/diff/1-2/

Comment 12

[Andreas Pehrson [:pehrsons]]

https://reviewboard.mozilla.org/r/59424/#review58132

padenot, could you just review the interdiff? Since jesup is on PTO.

I'm basically putting mConsumersToKeepAlive back (it was needed to not make bug 934512 worse) and cleaning up some.

Comment 13

[Paul Adenot (:padenot)]

Comment on attachment 8763090 [details]
Bug 1280445 - Remove wrapper from MediaStream.

https://reviewboard.mozilla.org/r/59424/#review58172

::: dom/media/DOMMediaStream.h:675
(Diff revision 2)
>  
>    // The interface through which we can query the stream producer for
>    // track sources.
>    RefPtr<MediaStreamTrackSourceGetter> mTrackSourceGetter;
>  
>    RefPtr<OwnedStreamListener> mOwnedListener;

Can we add a comment on those members ?

Comment 14

[Paul Adenot (:padenot)]

Comment on attachment 8766287 [details]
Bug 1280445 - Clean up MediaStreamAudioSourceNode's TrackListener on destruction.

https://reviewboard.mozilla.org/r/61264/#review58544

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2980e1dc86f2
Remove wrapper from MediaStream. r=jesup, r=padenot
https://hg.mozilla.org/integration/mozilla-inbound/rev/66dc5a74603a
Clear out all MediaSegments directly on forced MediaStreamGraph shutdown. r=jesup
https://hg.mozilla.org/integration/mozilla-inbound/rev/606dc72f3a62
Don't hold on to Image in MediaEngineDefaultVideoSource after Stop(). r=pehrsons
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fa9c9c4260d
Clean up MediaStreamAudioSourceNode's TrackListener on destruction. r=padenot

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2980e1dc86f2
https://hg.mozilla.org/mozilla-central/rev/66dc5a74603a
https://hg.mozilla.org/mozilla-central/rev/606dc72f3a62
https://hg.mozilla.org/mozilla-central/rev/5fa9c9c4260d