1280545 - Warning issued when using prefixed Fullscreen API, but unprefixed API is not available

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Tomer Lahav]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160604131506

Steps to reproduce:

See simple repro example here:
https://s3.amazonaws.com/storage2.interlude.fm/dev_temp/tomer/firefox_fullscreen_bug/ff_fullscreen.html


Actual results:

Using the prefixed Fullscreen API causes a warning to be issued:
"Prefixed Fullscreen API is deprecated."

However, there's no unprefixed API available.


Expected results:

Either unprefixed API should be made available, or no warning should be displayed.

Comment 1

[Alice0775 White]

The API is disabled by default, See Bug 1268749

If you want to use the API, set full-screen-api.unprefix.enabled to true in about:config.

Comment 2

[Masatoshi Kimura [:emk]]

(In reply to Alice0775 White from comment #1)
> The API is disabled by default, See Bug 1268749
> 
> If you want to use the API, set full-screen-api.unprefix.enabled to true in
> about:config.

Obviously site authors can't force users to flip the pref. We should suppress the warning if the pref is false.

Comment 3

[Masatoshi Kimura [:emk]]

Looks like the WebIDL [Deprecated] annotation cannot be conditional :(

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Bug 1280545 - Remove [Deprecated="PrefixedFullscreenAPI"] annotations until we are ready to unprefix fullscreen API.

Review commit: https://reviewboard.mozilla.org/r/61526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61526/

Comment 5

[Masatoshi Kimura [:emk]]

I intentionally left string changes to make uplift easier.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8766743 [details]
Bug 1280545 - Remove [Deprecated="PrefixedFullscreenAPI"] annotations until we are ready to unprefix fullscreen API.

https://reviewboard.mozilla.org/r/61526/#review58368

Hmmm... okay...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bedd6091246e
Remove [Deprecated="PrefixedFullscreenAPI"] annotations until we are ready to unprefix fullscreen API. r=xidorn

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8766743 [details]
Bug 1280545 - Remove [Deprecated="PrefixedFullscreenAPI"] annotations until we are ready to unprefix fullscreen API.

This one touches WebIDL and needs a DOM peer to review. (Though this isn't really a change to any API...)

Comment 9

[Carsten Book [:Tomcat]]

sorry had to back this out since this was running into the hook that prevent webidl changes without dom peer reviews. Seems mozreview/autoland did not noticed this and i filed bug 1283798 for this

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f7988afce2c
Backed out changeset bedd6091246e run into hg hook warning for webidl and backout for making autoland to m-c merge possible

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8766743 [details]
Bug 1280545 - Remove [Deprecated="PrefixedFullscreenAPI"] annotations until we are ready to unprefix fullscreen API.

https://reviewboard.mozilla.org/r/61526/#review58632

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ac069d1e022
Remove [Deprecated="PrefixedFullscreenAPI"] annotations until we are ready to unprefix fullscreen API. r=smaug,xidorn

Comment 13

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/3ac069d1e022

Comment 14

[Masatoshi Kimura [:emk]]

Comment on attachment 8766743 [details]
Bug 1280545 - Remove [Deprecated="PrefixedFullscreenAPI"] annotations until we are ready to unprefix fullscreen API.

Approval Request Comment
[Feature/regressing bug #]: 1268749
[User impact if declined]: Some advanced users and web authors will be confused by console messages.
[Describe test coverage new/current, TreeHerder]: Manually tested
[Risks and why]: Very low, only removes an auto-generated warning message.
[String/UUID change made/needed]: none. strings are left intact.

Comment 15

[Gerry Chang [:gchang]]

Comment on attachment 8766743 [details]
Bug 1280545 - Remove [Deprecated="PrefixedFullscreenAPI"] annotations until we are ready to unprefix fullscreen API.

This patch removes an auto-generated warning message. Take it in 48 beta 6 and aurora.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3534349c6d78

Comment 17

[Carsten Book [:Tomcat]]

has problems applying to beta:

grafting 352707:3534349c6d78 "Bug 1280545 - Remove [Deprecated="PrefixedFullscreenAPI"] annotations until we are ready to unprefix fullscreen API. r=smaug r=xidorn, a=gchang"
merging dom/webidl/Document.webidl
warning: conflicts while merging dom/webidl/Document.webidl! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 18

[Masatoshi Kimura [:emk]]

Attachment: patch for beta

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/85f50dde3d35