1280580 - Android native fling animation is returning an inverted velocity

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect, P2)

Description

[Randall Barker [:rbarker]]

The android native fling animation is returning the velocity inverted. This is causing permanent checkerboarding in some situations.

Comment 1

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1280580-Android-native-fling-animation-is-returning-an-inverted-velocity-r-16061710-ff50a23.patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8763193 [details] [diff] [review]
0001-Bug-1280580-Android-native-fling-animation-is-returning-an-inverted-velocity-r-16061710-ff50a23.patch

Review of attachment 8763193 [details] [diff] [review]:
-----------------------------------------------------------------

Check to see if this fixes bug 1280085 too.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f97c058ecdeb
Android native fling animation is returning an inverted velocity r=kats

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f97c058ecdeb

Comment 6

[Randall Barker [:rbarker]]

Comment on attachment 8763193 [details] [diff] [review]
0001-Bug-1280580-Android-native-fling-animation-is-returning-an-inverted-velocity-r-16061710-ff50a23.patch

Approval Request Comment
[Feature/regressing bug #]: End of page bounce animation plays at the wrong end of the page.
[User impact if declined]: Application will give incorrect user feedback when end of page is reached.
[Describe test coverage new/current, TreeHerder]: None, just manually verified.
[Risks and why]: Very low risk. Patch only negates the calculated velocity.
[String/UUID change made/needed]: none.

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8763193 [details] [diff] [review]
0001-Bug-1280580-Android-native-fling-animation-is-returning-an-inverted-velocity-r-16061710-ff50a23.patch

Review of attachment 8763193 [details] [diff] [review]:
-----------------------------------------------------------------

Fix a regression. Take it in 48 beta 4 and aurora.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fb650a44de9e

Comment 9

[Carsten Book [:Tomcat]]

has problems uplifting to beta 

merging gfx/layers/apz/src/AndroidAPZ.cpp
warning: conflicts while merging gfx/layers/apz/src/AndroidAPZ.cpp! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue

Comment 10

[Carsten Book [:Tomcat]]

worked after landing the other patch 

https://hg.mozilla.org/releases/mozilla-beta/rev/f63502a8a7ea

Comment 11

[Sorina Florean [:sflorean]]

Verified as fixed in build Firefox 48 Beta 6;
Device: LG G4 (Android 5.1).

Comment 12

[Sorina Florean [:sflorean]]

Verified as fixed in build Firefox 50.0a1 (2016-07-12);
Device: Prestigio Grace X5 (Android 4.4.2).

Comment 13

[Sorina Florean [:sflorean]]

Verified as fixed in build Firefox 49.0a2 (2016-07-17);
Device: LG G4 (Android 5.1).

Comment 14

[Alex Caziuc]

I'm changing the status to verified fixed considering that the bug is verified.