Closed Bug 1280580 Opened 3 years ago Closed 3 years ago

Android native fling animation is returning an inverted velocity

Categories

(Firefox for Android :: Toolbar, defect, P2)

48 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 50
Tracking Status
firefox47 --- unaffected
firefox48 --- verified
firefox49 --- verified
firefox50 --- verified

People

(Reporter: rbarker, Assigned: rbarker)

References

Details

(Keywords: regression)

Attachments

(1 file)

The android native fling animation is returning the velocity inverted. This is causing permanent checkerboarding in some situations.
Comment on attachment 8763193 [details] [diff] [review]
0001-Bug-1280580-Android-native-fling-animation-is-returning-an-inverted-velocity-r-16061710-ff50a23.patch

Review of attachment 8763193 [details] [diff] [review]:
-----------------------------------------------------------------

Check to see if this fixes bug 1280085 too.
Attachment #8763193 - Flags: review?(bugmail.mozilla) → review+
Assignee: nobody → rbarker
Priority: -- → P2
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f97c058ecdeb
Android native fling animation is returning an inverted velocity r=kats
https://hg.mozilla.org/mozilla-central/rev/f97c058ecdeb
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment on attachment 8763193 [details] [diff] [review]
0001-Bug-1280580-Android-native-fling-animation-is-returning-an-inverted-velocity-r-16061710-ff50a23.patch

Approval Request Comment
[Feature/regressing bug #]: End of page bounce animation plays at the wrong end of the page.
[User impact if declined]: Application will give incorrect user feedback when end of page is reached.
[Describe test coverage new/current, TreeHerder]: None, just manually verified.
[Risks and why]: Very low risk. Patch only negates the calculated velocity.
[String/UUID change made/needed]: none.
Attachment #8763193 - Flags: approval-mozilla-beta?
Attachment #8763193 - Flags: approval-mozilla-aurora?
No longer blocks: 1276463
Depends on: 1276463
Comment on attachment 8763193 [details] [diff] [review]
0001-Bug-1280580-Android-native-fling-animation-is-returning-an-inverted-velocity-r-16061710-ff50a23.patch

Review of attachment 8763193 [details] [diff] [review]:
-----------------------------------------------------------------

Fix a regression. Take it in 48 beta 4 and aurora.
Attachment #8763193 - Flags: approval-mozilla-beta?
Attachment #8763193 - Flags: approval-mozilla-beta+
Attachment #8763193 - Flags: approval-mozilla-aurora?
Attachment #8763193 - Flags: approval-mozilla-aurora+
has problems uplifting to beta 

merging gfx/layers/apz/src/AndroidAPZ.cpp
warning: conflicts while merging gfx/layers/apz/src/AndroidAPZ.cpp! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
Flags: needinfo?(rbarker)
worked after landing the other patch 

https://hg.mozilla.org/releases/mozilla-beta/rev/f63502a8a7ea
Flags: needinfo?(rbarker)
Verified as fixed in build Firefox 48 Beta 6;
Device: LG G4 (Android 5.1).
Version: unspecified → 48 Branch
Verified as fixed in build Firefox 50.0a1 (2016-07-12);
Device: Prestigio Grace X5 (Android 4.4.2).
Verified as fixed in build Firefox 49.0a2 (2016-07-17);
Device: LG G4 (Android 5.1).
I'm changing the status to verified fixed considering that the bug is verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.