1280601 - Add lastKnownTitle to onVisit

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P3)

Description

[Bob Silverberg [:bsilverberg]]

As discussed in bug 1265845, in order to mimic Chrome's onVisited API event, we should deliver the last known title for a page in onVisited. We can do this if the title is provided to us via the onVisit event.

Perhaps we should call it `lastKnownTitle` in onVisit to be clear that it is not the title from the current visit, but rather the last known title of the page. If there is no known title it would return an empty string.

Comment 1

[Marco Bonardo [:mak]]

+1 on the API naming.

Comment 2

[Bob Silverberg [:bsilverberg]]

Thanks for taking this, Kris. I'd really like to land bug 1280357 before the end of the month. Do you think you'll be able to land this change before then?

Comment 3

[Kris Maglione [:kmag]]

Is there a particular reason this needs to be done before the end of the month? The next merge isn't until August, and Andy has told me that I shouldn't treat this API as a particularly high priority for the moment. I was planning to take care of it when I'm back in the states at the end of next week.

Comment 4

[Bob Silverberg [:bsilverberg]]

The only reason is that this is part of my Q2 deliverable, which was to complete the implementation of the history API, but I think we can consider it basically complete with only a couple of minor enhancement bugs still open, so don't worry about it. I didn't realize you were still traveling and it's fine to leave it until you get back.

Comment 5

[Marco Bonardo [:mak]]

Fixed by bug 1341097