Closed Bug 1287928 Opened 8 years ago Closed 7 years ago

Update browser.history.onVisited to use the title from the onVisit event

Categories

(WebExtensions :: Compatibility, defect, P3)

Product:
WebExtensions
Component:
Compatibility
Type:
defect

Tracking

(firefox56 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: bsilverberg, Assigned: wisniewskit)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [history]triaged)

Attachments

(1 file)

1287928-update_browser.history.onVisited_to_use_the_title_from_the_onVisit_event.diff
2.73 KB, patch
mixedpuppy
: review+
Details | Diff | Splinter Review 
Once bug 1280601 lands, update the onVisited event to include the title. Currently onVisited just delivers an empty string as the title.
Blocks: 1208334
Unassigning myself and switching it to Thomas as he seems to be working on it. Thanks Thomas!
Assignee: bob.silverberg → wisniewskit
Attachment #8879704 - Flags: review?(mixedpuppy) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1824f9dc9ba
Update browser.history.onVisited to use the title from the onVisit event. r=mixedpuppy
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a1824f9dc9ba
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
I've updated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/history/onVisited.

Please let me know if we need anything else!
Flags: needinfo?(wisniewskit)
Thanks, I think that'll do.
Flags: needinfo?(wisniewskit)
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: