Closed
Bug 1287928
Opened 9 years ago
Closed 8 years ago
Update browser.history.onVisited to use the title from the onVisit event
Categories
(WebExtensions :: Compatibility, defect, P3)
WebExtensions
Compatibility
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: bsilverberg, Assigned: wisniewskit)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [history]triaged)
Attachments
(1 file)
2.73 KB,
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
Once bug 1280601 lands, update the onVisited event to include the title. Currently onVisited just delivers an empty string as the title.
Assignee | ||
Comment 1•8 years ago
|
||
Here's a patch. A try run seems fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3297c4681991647a773a5f412845bb84163379f6
Attachment #8879704 -
Flags: review?(mixedpuppy)
Reporter | ||
Comment 2•8 years ago
|
||
Unassigning myself and switching it to Thomas as he seems to be working on it. Thanks Thomas!
Assignee: bob.silverberg → wisniewskit
Updated•8 years ago
|
Attachment #8879704 -
Flags: review?(mixedpuppy) → review+
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1824f9dc9ba
Update browser.history.onVisited to use the title from the onVisit event. r=mixedpuppy
Keywords: checkin-needed
Comment 4•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•8 years ago
|
Keywords: dev-doc-needed
Comment 5•8 years ago
|
||
I've updated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/history/onVisited.
Please let me know if we need anything else!
Flags: needinfo?(wisniewskit)
Updated•8 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
Updated•7 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•