Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Update browser.history.onVisited to use the title from the onVisit event

RESOLVED FIXED in Firefox 56

Status

()

Toolkit
WebExtensions: Compatibility
P3
normal
RESOLVED FIXED
a year ago
23 days ago

People

(Reporter: bsilverberg, Assigned: Thomas Wisniewski)

Tracking

({dev-doc-needed})

unspecified
mozilla56
dev-doc-needed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [history]triaged)

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Once bug 1280601 lands, update the onVisited event to include the title. Currently onVisited just delivers an empty string as the title.
(Reporter)

Updated

a year ago
Blocks: 1208334
(Assignee)

Comment 1

a month ago
Created attachment 8879704 [details] [diff] [review]
1287928-update_browser.history.onVisited_to_use_the_title_from_the_onVisit_event.diff

Here's a patch. A try run seems fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3297c4681991647a773a5f412845bb84163379f6
Attachment #8879704 - Flags: review?(mixedpuppy)
(Reporter)

Comment 2

a month ago
Unassigning myself and switching it to Thomas as he seems to be working on it. Thanks Thomas!
Assignee: bob.silverberg → wisniewskit
Attachment #8879704 - Flags: review?(mixedpuppy) → review+
Keywords: checkin-needed

Comment 3

23 days ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1824f9dc9ba
Update browser.history.onVisited to use the title from the onVisit event. r=mixedpuppy
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a1824f9dc9ba
Status: ASSIGNED → RESOLVED
Last Resolved: 23 days ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.