Closed Bug 1280698 Opened 8 years ago Closed 8 years ago

Package EmojiOne TTF font on Linux and Windows

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set
normal

Tracking

(seamonkey2.49esr fixed)

RESOLVED FIXED
seamonkey2.49
Tracking Status
seamonkey2.49esr --- fixed

People

(Reporter: philip.chee, Assigned: philip.chee, Mentored)

References

Details

(Whiteboard: [good first bug][gfb][packager])

User Story

In Bug 1231701 the EmojiOne TTF font is packaged and shipped for Firefox Windows and Linux. We should do the same for SeaMonkey.

Attachments

(2 files)

See Bug 1231701 (Ship an emoji font on Windows XP-7)

> Windows XP has close to no native support for emoji. Even on Windows 7 the
> set is very limited and not very appealing.
> 
> We have a very well developed emoji font from Firefox OS. We should bundle
> that font with the browser on those platforms.
Mentor: philip.chee, iann_bugzilla
User Story: (updated)
Whiteboard: [good first bug][gfb][packager]
Depends on: 1299556
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #8789550 - Flags: review?(iann_bugzilla)
Comment on attachment 8789550 [details] [diff] [review]
Patch to package the EmojiOne font.

I know this matches what browser and b2g do, just wondering why MOZ_BUNDLED_FONTS isn't used in package-manifest.in
r/a=me
Attachment #8789550 - Flags: review?(iann_bugzilla) → review+
Hm. Not sure if relevant. After Firefox 51.0a1 installation, the font is unpacked as <installdir>/fonts/EmojiOneMozilla.ttf (e.g. /usr/local/firefox/fonts/EmojiOneMozilla.ttf) with no /browser/ dirname in the path.
(In reply to Tony Mechelynck [:tonymec] from comment #3)
> Hm. Not sure if relevant. After Firefox 51.0a1 installation, the font is
> unpacked as <installdir>/fonts/EmojiOneMozilla.ttf (e.g.
> /usr/local/firefox/fonts/EmojiOneMozilla.ttf) with no /browser/ dirname in
> the path.
/browser/fonts/ is the "source" (in mozilla-central)
<installdir>/fonts/EmojiOneMozilla.ttf is the {install) "destination" on your hard disk.
(In reply to Ian Neal from comment #2)
> I know this matches what browser and b2g do, just wondering why
> MOZ_BUNDLED_FONTS isn't used in package-manifest.in
> r/a=me

This version centralises the logic in MOZ_BUNDLED_FONTS at the expense of greater verbosity.
Attachment #8794459 - Flags: review?(iann_bugzilla)
Comment on attachment 8794459 [details] [diff] [review]
Patch v2 Another approach: Centralize logic with MOZ_BUNDLED_FONTS

LGTM, just curious why Firefox didn't take this approach... r/a=me
Attachment #8794459 - Flags: review?(iann_bugzilla) → review+
http://hg.mozilla.org/comm-central/rev/f03dbcdc6fe9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.49
See Also: → 638335
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: