Fix test_create after "Bug 1276216 - All tasks with no other dependencies should depend on the decision task"

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
9 months ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8763525 [details] [diff] [review]
[m-c] fix the test

+++ This bug was initially created as a clone of Bug #1276216 +++

After Bug 1276216 we are failing in test_create.py with:

ERROR: test_create_tasks (taskgraph.test.test_create.TestCreate)
Traceback (most recent call last):
  File "/home/callek/mozilla/hg/mozilla-central/taskcluster/taskgraph/test/test_create.py", line 55, in test_create_tasks
    create.create_tasks(taskgraph, label_to_taskid)
  File "/home/callek/mozilla/hg/mozilla-central/taskcluster/taskgraph/create.py", line 52, in create_tasks
    deps_fs = [fs[dep] for dep in task_def['dependencies'] if dep in fs]
KeyError: u'dependencies'
Attachment #8763525 - Flags: review?(dustin)
Assignee: nobody → bugspam.Callek
Comment on attachment 8763525 [details] [diff] [review]
[m-c] fix the test

Review of attachment 8763525 [details] [diff] [review]:
-----------------------------------------------------------------

Need the bug ID in the commit message, but good fix.
Attachment #8763525 - Flags: review?(dustin) → review+

Comment 2

2 years ago
Pushed by Callek@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/57f790e0daff
Fix test_create after "Bug 1276216 - All tasks with no other dependencies should depend on the decision task"

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/57f790e0daff
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Updated

9 months ago
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.