128098 - Index should be expanded by default

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Rafael Ebron (:rebron)]

Looks awkward just having the alphabet in there with twisty icons.  We should
have the index default expanded to display content.  This should only be a first
level expand, i.e. 
A 
  Add

Not A 
      Add
          Brower settings
          Bookmarks

Comment 1

[Ian Oeschger (gone)]

Just what I am working on right now, Rafael. And exactly as you describe it
here, too: all letters opened, rest collapsed. Thanks. Good spot.

Comment 2

[Ian Oeschger (gone)]

Attachment: small update to open the top-level items when the index displays

Comment 3

[Ian Oeschger (gone)]

Attachment: modification

modification based on jan varga's good suggestion.

Comment 4

[Ian Oeschger (gone)]

Attachment: new replacement for index opening

Last update was incomplete. And didn't work neither. This guy does it.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 74025 [details] [diff] [review]
new replacement for index opening

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 6

[Ian Oeschger (gone)]

Marking FIXED.

Comment 7

[Ian Oeschger (gone)]

Reopening this. The outliner->tree update orphaned my
document.getElementById("help-index-outliner") grab in the displayIndex()
function. Patch coming very soon.

Comment 8

[Ian Oeschger (gone)]

Attachment: get reference to index *tree*

this one-liner fixes a small regression from the outliner->tree fix last week.

Comment 9

[rudman]

Marking for rtm, setting milestone. Usability test of the help indicated that
this would be a significant usability fix.

Comment 10

[andreww]

Comment on attachment 77063 [details] [diff] [review]
get reference to index *tree*

r=andreww

Comment 11

[[e-mail]]

The cause of this problem is the same as for bug 123719.
For the branch, the "quick fix" is:
function displayIndex() {
  if (!helpIndexPanel.view)
    helpIndexPanel.view = helpIndexPanel.builder;
  var treeview = helpIndexPanel.view;
  var i = treeview.rowCount;
  while (i--)
    if (!treeview.getLevel(i) && !treeview.isContainerOpen(i)) {
      treeview.toggleOpenState(i);
}

Comment 12

[Ian Oeschger (gone)]

Thanks, Neil! Let's call your most recent comment the patch, and me the
reviewer: r=oeschger. I've tested this and it works fine. Looks like you can't
assume there is a view available.

Comment 13

[Alec Flett]

Comment on attachment 77063 [details] [diff] [review]
get reference to index *tree*

sr=alecf

Comment 14

[[e-mail]]

Attachment: Proposed patch

I misbraced my comment, this is the correct code as a patch.

Comment 15

[Ian Oeschger (gone)]

Comment on attachment 86472 [details] [diff] [review]
Proposed patch

r=oeschger. formalizing what's implicit in these comments

Comment 16

[Alec Flett]

Comment on attachment 86472 [details] [diff] [review]
Proposed patch

sr=alecf

Comment 17

[[e-mail]]

Fix was checked in by timeless.

Comment 18

[Sean Cotter]

This is not fixed on in the trunk or branch commercial builds of 6/17/2002. The
index still does not open up all the way by default.

Comment 19

[Sean Cotter]

My mistake. Profile error. It is in fact fixed on the trunk. The index in a new
profile opens to the first level of entries, which is fine.

This fix is baked and ready for the branch.

Comment 20

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 21

[Paul Wyskoczka]

Adding adt1.0.1+ on behalf of the adt.  Please chech the fix into the Mozilla
1.0 branch.

Comment 22

[Navin Gupta]

fixed on branch.

Comment 23

[Terri Preston]

Verified win xp branch build 2002062005, Linux branch build 2002062006 and Mac
OS X branch build 2002062008

and

Verified win 2k trunk build 2002062008, Linux trunk build 2002062011 and Mac OS
X trunk build 2002062002