Closed Bug 1281275 Opened 9 years ago Closed 9 years ago

TSan: enabledTextIds data race

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The main thread calls Debugger::setupTraceLogger -> TraceLogEnableTextId A background compilation thread does CodeGeneratorShared::emitTracelogScript -> TraceLogTextIdEnabled. Should we cancel compilations before we change TraceLogger settings?
Flags: needinfo?(hv1989)
we call ReleaseAllJITCode in TraceLoggerThreadState::enableTextId. IIUC that should cancel all compilations currently happening, right?
Flags: needinfo?(hv1989)
Attached patch PatchSplinter Review
(In reply to Hannes Verschore [:h4writer] from comment #1) > we call ReleaseAllJITCode in TraceLoggerThreadState::enableTextId. > IIUC that should cancel all compilations currently happening, right? Ah yes, we just have to cancel before we change the arrays. This fixes the TSan failure.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Attachment #8764126 - Flags: review?(hv1989)
Attachment #8764126 - Flags: review?(hv1989) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd168681220 Fix a TSan data race in TraceLogger enabledTextIds. r=h4writer
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: