Closed
Bug 1281275
Opened 9 years ago
Closed 9 years ago
TSan: enabledTextIds data race
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.82 KB,
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
The main thread calls Debugger::setupTraceLogger -> TraceLogEnableTextId
A background compilation thread does CodeGeneratorShared::emitTracelogScript -> TraceLogTextIdEnabled.
Should we cancel compilations before we change TraceLogger settings?
Flags: needinfo?(hv1989)
Comment 1•9 years ago
|
||
we call ReleaseAllJITCode in TraceLoggerThreadState::enableTextId.
IIUC that should cancel all compilations currently happening, right?
Flags: needinfo?(hv1989)
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to Hannes Verschore [:h4writer] from comment #1)
> we call ReleaseAllJITCode in TraceLoggerThreadState::enableTextId.
> IIUC that should cancel all compilations currently happening, right?
Ah yes, we just have to cancel before we change the arrays. This fixes the TSan failure.
Updated•9 years ago
|
Attachment #8764126 -
Flags: review?(hv1989) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd168681220
Fix a TSan data race in TraceLogger enabledTextIds. r=h4writer
Comment 4•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•