Closed
Bug 1281686
Opened 8 years ago
Closed 8 years ago
Consider using IOSurface for RectTextureImage.
Categories
(Core :: Widget: Cocoa, defect, P1)
Core
Widget: Cocoa
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: mtseng, Assigned: mtseng)
References
Details
Attachments
(3 files, 2 obsolete files)
|
4.01 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
|
22.00 KB,
patch
|
mtseng
:
review+
|
Details | Diff | Splinter Review |
|
16.46 KB,
patch
|
mtseng
:
review+
|
Details | Diff | Splinter Review |
Per bug 1271870 comment 21, this will improve performance for BasicCompositor on OSX.
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
|
Assignee | |
Comment 3•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → mtseng
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8765351 [details] [diff] [review] Part 2: Move RectTextureImage to separate file. r=mstange (carry r+: mstange) Carry r+ from bug 1271870
Attachment #8765351 -
Attachment description: Part 2: Move RectTextureImage to separate file. r=mstange → Part 2: Move RectTextureImage to separate file. r=mstange (carry r+: mstange)
Attachment #8765351 -
Flags: review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8765352 [details] [diff] [review] Part 3: Using MacIOSurface for RectTextureImage. r=mstange (carry r+: mstange) Carry r+ from bug 1271870.
Attachment #8765352 -
Attachment description: Part 3: Using MacIOSurface for RectTextureImage. r=mstange → Part 3: Using MacIOSurface for RectTextureImage. r=mstange (carry r+: mstange)
Attachment #8765352 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8765350 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 6•8 years ago
|
||
try https://treeherder.mozilla.org/#/jobs?repo=try&revision=73cc805fc445
|
||
Updated•8 years ago
|
Attachment #8765350 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8765352 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 8•8 years ago
|
||
Previous patch is wrong. upload correct patch.
Attachment #8766164 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8766163 -
Attachment is obsolete: true
Pushed by mtseng@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/73fdb982a09d Part 1: Fix OSX Compile failure due to unified build. r=mstange https://hg.mozilla.org/integration/mozilla-inbound/rev/a617a1114718 Part 2: Move RectTextureImage to separate file. r=mstange https://hg.mozilla.org/integration/mozilla-inbound/rev/3d40da5e5769 Part 3: Using MacIOSurface for RectTextureImage. r=mstange
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/73fdb982a09d https://hg.mozilla.org/mozilla-central/rev/a617a1114718 https://hg.mozilla.org/mozilla-central/rev/3d40da5e5769
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
||
Comment 11•8 years ago
|
||
thanks for the perf improvement on our new video talos test: https://treeherder.mozilla.org/perf.html#/alerts?id=1644
You need to log in
before you can comment on or make changes to this bug.
Description
•