Closed Bug 1281686 Opened 9 years ago Closed 9 years ago

Consider using IOSurface for RectTextureImage.

Categories

(Core :: Widget: Cocoa, defect, P1)

Product:
Core
Component:
Widget: Cocoa
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: mtseng, Assigned: mtseng)

References

Details

Attachments

(3 files, 2 obsolete files)

Part 1: Fix OSX Compile failure due to unified build. r=mstange
4.01 KB, patch
mstange
: review+
Details | Diff | Splinter Review
Part 2: Move RectTextureImage to separate file. r=mstange (carry r+: mstange)
22.00 KB, patch
mtseng
: review+
Details | Diff | Splinter Review
Part 3: Using MacIOSurface for RectTextureImage v3. (carry r+: mstange)
16.46 KB, patch
mtseng
: review+
Details | Diff | Splinter Review
Per bug 1271870 comment 21, this will improve performance for BasicCompositor on OSX.
Assignee: nobody → mtseng
Comment on attachment 8765351 [details] [diff] [review] Part 2: Move RectTextureImage to separate file. r=mstange (carry r+: mstange) Carry r+ from bug 1271870
Attachment #8765351 - Attachment description: Part 2: Move RectTextureImage to separate file. r=mstange → Part 2: Move RectTextureImage to separate file. r=mstange (carry r+: mstange)
Attachment #8765351 - Flags: review+
Comment on attachment 8765352 [details] [diff] [review] Part 3: Using MacIOSurface for RectTextureImage. r=mstange (carry r+: mstange) Carry r+ from bug 1271870.
Attachment #8765352 - Attachment description: Part 3: Using MacIOSurface for RectTextureImage. r=mstange → Part 3: Using MacIOSurface for RectTextureImage. r=mstange (carry r+: mstange)
Attachment #8765352 - Flags: review+
Attachment #8765350 - Flags: review?(mstange)
Attachment #8765350 - Flags: review?(mstange) → review+
Attachment #8765352 - Attachment is obsolete: true
Previous patch is wrong. upload correct patch.
Attachment #8766164 - Flags: review+
Attachment #8766163 - Attachment is obsolete: true
Pushed by mtseng@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/73fdb982a09d Part 1: Fix OSX Compile failure due to unified build. r=mstange https://hg.mozilla.org/integration/mozilla-inbound/rev/a617a1114718 Part 2: Move RectTextureImage to separate file. r=mstange https://hg.mozilla.org/integration/mozilla-inbound/rev/3d40da5e5769 Part 3: Using MacIOSurface for RectTextureImage. r=mstange
thanks for the perf improvement on our new video talos test: https://treeherder.mozilla.org/perf.html#/alerts?id=1644
Depends on: 1284440
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: