Closed Bug 1284440 Opened 5 years ago Closed 5 years ago
Rendering issue occurs after restarting without HWA (or in Safe Mode) in OS X
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0 Build ID: 20160704030211 Steps to reproduce: 1. Start Nightly in OS X 2. Restart in Safe Mode 3. Open Bookmarks sidebar Actual results: Rendering issue occurs after restarting in Safe Mode. Especially when opening sidebar. (I can reproduce this issue in Yosemite and El Capitan) Expected results: Rendering works in Safe Mode
Regression range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=074b708b01394ba7c4d8b9dc07858851c6a218e4&tochange=3d40da5e57699583afb009a9978d954e0e034049
Has Regression Range: --- → yes
Assignee: nobody → mtseng
Another STR: Start Nightly without hardware acceleration in OS X
Summary: Rendering issue occurs after restarting in Safe Mode in OS X → Rendering issue occurs after restarting without HWA (or in Safe Mode) in OS X
Duplicate of this bug: 1284506
CreateRenderTargetForWindow might clear too aggressive which means it would clear unwanted area. So I add ClipToRegion in advance to prevent it from clearing those unwanted area.
Attachment #8768328 - Flags: review?(matt.woodrow)
Attachment #8768328 - Flags: review?(matt.woodrow) → review+
Try looks good. The orange happened on OSX is caused by another commit.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c8700e65f41b Prevent CreateRenderTargetForWindow from clearing unwanted area. r=mattwoodrow
We should back this out.
Backed this out for graphic issues on Linux, see bug 1285243.
Backout by firstname.lastname@example.org: https://hg.mozilla.org/mozilla-central/rev/63cc31d6cc1c Backed out changeset c8700e65f41b for causing graphic issues (bug 1285243). r=backout
This should fix problem on linux.
Attachment #8769059 - Flags: review+
Attachment #8768328 - Attachment is obsolete: true
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2ada5807b65d Prevent CreateRenderTargetForWindow from clearing unwanted area. r=mattwoodrow
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
This patch did a perf improvement, https://treeherder.mozilla.org/perf.html#/graphs?series=%5Bmozilla-inbound,97875da197b1dc5730cc28037b1fcc56012fd730,1,1%5D&zoom=1467839846736.0076,1467938616967.3508,2.5671641791044775,2.9925373134328357&selected=%5Bmozilla-inbound,97875da197b1dc5730cc28037b1fcc56012fd730,34165,31334049,1%5D
Morris, can you add a test that would've caught the bug in the original patch?
I believe Michael is doing this. Michael, can you file a follow-up bug for this test case? Thanks.
Flags: needinfo?(mtseng) → needinfo?(cleu)
Yes, I'm investigating this issue. I have filed a follow-up bug. bug1287986
I was able to reproduce this issue on an older Nightly 50.0a1 from 2016-07-05. The is verified fixed on Firefox 50.0b3-build1 (2016-09-29) running Mac OS X 10.10 and 10.11.
You need to log in before you can comment on or make changes to this bug.