1282466 - Let's add a desktop notification after a screenshot has been taken.

Status: NEW

(DevTools :: General, enhancement, P3)

Description

[Helen V. Holmes (:helenvholmes) (:✨)]

(In reply to Patrick Brosset <:pbro> from comment #3)
> May I also suggest adding a desktop notification? We can do those easily
> now, and they're pretty great!

I think a notification after you've taken a screenshot is a great idea. I think this bug should also handle removing the fading animation to the download panel that we currently have.

Candidates for screenshot notification:
- location of where it's saved
- name given to screenshot

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Is there a major delay between taking the screenshot and saving it? If not, I personally think this would be misuse of desktop notifications. They are very good for grabbing attention for something that happend in the background. A more in-context notification may be preferable.

Comment 2

[Helen V. Holmes (:helenvholmes) (:✨)]

Attachment: image00-13.gif

I did some investigation and it looks like the Taipei team has already done some work around Downloads that looks really well-done. While I think notifications could be done in a way that isn't too bad (here's cloud.ly, which I think does them well: http://cl.ly/0n0k3m3h0n1f) I think it makes more sense to use work that's already been completed :) 

Patrick, since you originally suggested the notification, does that sound all right to you?

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Helen V. Holmes (:helenvholmes) (:✨)(pls ni?) from comment #0)
> (In reply to Patrick Brosset <:pbro> from comment #3)
> > May I also suggest adding a desktop notification? We can do those easily
> > now, and they're pretty great!
> 
> I think a notification after you've taken a screenshot is a great idea. I
> think this bug should also handle removing the fading animation to the
> download panel that we currently have.

Should the screenshot also be removed from the downloads list as well?  At the moment, the screenshot code uses the general Firefox "save to downloads" functionality which does all 3 of:

1. Save to the user's downloads folder by default
2. Pulse the downloads icon
3. Add an entry to downloads list

We could go our own way entirely with a separate saving path, custom notification, etc.  It could be hard to keep only a portion of the current set of 3 items above because it all comes together as package of things that happen for "save to downloads".

Would it be more integrated with the Firefox UI visually to continue with the current path (using the code for downloads like we do) instead of something more custom?  It seems like the Taipei team's work could be implemented for all Firefox downloads and our current screenshot code would get it for free (since we use the same "save to downloads" path like downloading other things).

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Philipp Kewisch [:Fallen] from comment #1)
> Is there a major delay between taking the screenshot and saving it? If not,
> I personally think this would be misuse of desktop notifications. They are
> very good for grabbing attention for something that happend in the
> background. A more in-context notification may be preferable.

It's quite fast, so I see what you mean here.  The current download flashing animation is trying to say "the screenshot went to your downloads folder".  A larger notification would give us the option to more explicitly state where it actually went, and possibly offer something to click to reveal the folder in your OS.

You may be right that something in-context is better, since it's not a long running background task (which is the common use case for desktop notifications).

Comment 5

[Helen V. Holmes (:helenvholmes) (:✨)]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> > I think a notification after you've taken a screenshot is a great idea. I
> > think this bug should also handle removing the fading animation to the
> > download panel that we currently have.
I do too! I'm kinda ambivalent about it being a desktop notification specifically and I like the work Carol's done (see image00-13.gif attachment) so I think we should stay in sync with that work. 

Looking at her designs, looks like they've decided to keep the fading animation. Can't edit comments, so please ignore what I said in Comment #0 about removing it.

> Should the screenshot also be removed from the downloads list as well?  At
> the moment, the screenshot code uses the general Firefox "save to downloads"
> functionality which does all 3 of:
> 
> 1. Save to the user's downloads folder by default
> 2. Pulse the downloads icon
> 3. Add an entry to downloads list

I think we should probably continue to keep screenshots as Downloads based on your second conclusion, Ryan:

> Would it be more integrated with the Firefox UI visually to continue with
> the current path (using the code for downloads like we do) instead of
> something more custom?  It seems like the Taipei team's work could be
> implemented for all Firefox downloads and our current screenshot code would
> get it for free (since we use the same "save to downloads" path like
> downloading other things).

Comment 6

[Helen V. Holmes (:helenvholmes) (:✨)]

A description of the Taipei work can be seen here: https://mana.mozilla.org/wiki/display/PM/Content+Handling+Enhancement

I think we should hold off on this bug until that work gets underway.

(Going to clear Patrick's ni? based on this info.)